openai/CLIP
1
0
Fork 0
mirror of https://github.com/openai/CLIP.git synced 2026-11-05 01:37:26 +00:00
Code Issues 274 Projects Packages Wiki Activity

[PR #170] [CLOSED] Fixes #169: Compare version using integers #469

New issue
Closed
opened 2026-10-31 21:15:18 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 21:15:18 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/openai/CLIP/pull/170
Author: @matthewfranglen
Created: 11/1/2021
Status: ❌ Closed

Base: main ← Head: issue-169

📝 Commits (1)

  • 73228e6 Compare version using integers

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 clip/clip.py (+1 -1)

📄 Description

pytorch version 1.10 has been released and this causes the version check
to erroneously fail. This fixes that comparison.

>>> [1, 10, 0] < [1, 7, 1]
False
>>> ["1", "10", "0"] < ["1", "7", "1"]
True
```

---

<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
## 📋 Pull Request Information **Original PR:** https://github.com/openai/CLIP/pull/170 **Author:** [@matthewfranglen](https://github.com/matthewfranglen) **Created:** 11/1/2021 **Status:** ❌ Closed **Base:** `main` ← **Head:** `issue-169` --- ### 📝 Commits (1) - [`73228e6`](https://github.com/openai/CLIP/commit/73228e6c950c7881f4f9d0a7236539b30c38f275) Compare version using integers ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `clip/clip.py` (+1 -1) </details> ### 📄 Description pytorch version 1.10 has been released and this causes the version check to erroneously fail. This fixes that comparison. ```` >>> [1, 10, 0] < [1, 7, 1] False >>> ["1", "10", "0"] < ["1", "7", "1"] True ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 21:15:18 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/pin-github-workflow-refs-20260325-132838
jongwook/issue-396
jongwook-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
openai/CLIP#469
No description provided.