mirror of
https://github.com/openai/CLIP.git
synced 2026-11-05 01:37:26 +00:00
[PR #290] Accept Sequence instead of List #485
Labels
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
openai/CLIP#485
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/openai/CLIP/pull/290
Author: @jangop
Created: 9/14/2022
Status: 🔄 Open
Base:
main← Head:patch-1📝 Commits (1)
b118307AcceptSequenceinstead ofList📊 Changes
1 file changed (+2 additions, -2 deletions)
View changed files
📝
clip/clip.py(+2 -2)📄 Description
This is minor, I know.
tokenizesimply iterates overtexts, so in addition tolist,tupleis fine. The intended type hint for this isSequence.I am not sure which version of Python this project targets, but judging from the other type hints in this file, I am going to assume
<3.9. Otherwise, I would suggest importingSequencefromcollections.abcinstead oftyping.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.