openai/CLIP
1
0
Fork 0
mirror of https://github.com/openai/CLIP.git synced 2026-11-05 01:37:26 +00:00
Code Issues 274 Projects Packages Wiki Activity

[PR #372] [MERGED] Fix torch._C.Node attribute access #492

New issue
Closed
opened 2026-10-31 21:15:30 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 21:15:30 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/openai/CLIP/pull/372
Author: @jamt9000
Created: 7/6/2023
Status: ✅ Merged
Merged: 7/8/2023
Merged by: @jongwook

Base: main ← Head: james/torch2-getnode-fix

📝 Commits (1)

  • 2dbac90 Fix torch._C.Node attribute access

📊 Changes

1 file changed (+10 additions, -2 deletions)

View changed files

📝 clip/clip.py (+10 -2)

📄 Description

Attribute access of a JIT graph node with subscripting would previously work due to patching in https://github.com/pytorch/pytorch/pull/82511 but this has been removed.

This commit uses the fix proposed in https://github.com/pytorch/pytorch/pull/82628 to define a helper method to call the appropriate access method.

Fixes https://github.com/openai/CLIP/issues/79 for Pytorch 2.0.0

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/openai/CLIP/pull/372 **Author:** [@jamt9000](https://github.com/jamt9000) **Created:** 7/6/2023 **Status:** ✅ Merged **Merged:** 7/8/2023 **Merged by:** [@jongwook](https://github.com/jongwook) **Base:** `main` ← **Head:** `james/torch2-getnode-fix` --- ### 📝 Commits (1) - [`2dbac90`](https://github.com/openai/CLIP/commit/2dbac9065bb0b4ffc28ecf0e94758261d1ddfdb0) Fix torch._C.Node attribute access ### 📊 Changes **1 file changed** (+10 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `clip/clip.py` (+10 -2) </details> ### 📄 Description Attribute access of a JIT graph node with subscripting would previously work due to patching in https://github.com/pytorch/pytorch/pull/82511 but this has been removed. This commit uses the fix proposed in https://github.com/pytorch/pytorch/pull/82628 to define a helper method to call the appropriate access method. Fixes https://github.com/openai/CLIP/issues/79 for Pytorch 2.0.0 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 21:15:30 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/pin-github-workflow-refs-20260325-132838
jongwook/issue-396
jongwook-patch-1
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
openai/CLIP#492
No description provided.