fix(clang-tidy): clang-tidy readability and misc fixes, like adding const (#3052)

* Enable and apply clang-tidy readability and misc fixes.

* Revert deprecated tester

* add space to tests/test_constants_and_functions.cpp
This commit is contained in:
Aaron Gokaslan
2021-06-21 10:37:48 -04:00
committed by GitHub
parent d00fc62931
commit 3b30b0a51e
16 changed files with 52 additions and 33 deletions

View File

@@ -48,12 +48,12 @@ int VanillaStaticMix2::static_value = 12;
// test_multiple_inheritance_virtbase
struct Base1a {
Base1a(int i) : i(i) { }
int foo() { return i; }
int foo() const { return i; }
int i;
};
struct Base2a {
Base2a(int i) : i(i) { }
int bar() { return i; }
int bar() const { return i; }
int i;
};
struct Base12a : Base1a, Base2a {
@@ -78,7 +78,7 @@ TEST_SUBMODULE(multiple_inheritance, m) {
// test_multiple_inheritance_mix2
struct Base1 {
Base1(int i) : i(i) { }
int foo() { return i; }
int foo() const { return i; }
int i;
};
py::class_<Base1> b1(m, "Base1");
@@ -87,7 +87,7 @@ TEST_SUBMODULE(multiple_inheritance, m) {
struct Base2 {
Base2(int i) : i(i) { }
int bar() { return i; }
int bar() const { return i; }
int i;
};
py::class_<Base2> b2(m, "Base2");