pybind/pybind11
1
0
Fork 0
mirror of https://github.com/pybind/pybind11.git synced 2026-05-05 14:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Properly translate C++ exception to Python exception when creating Python buffer from wrapped object (#5324)

Browse Source 
* Add test for throwing def_buffer case

* Translate C++ -> Python exceptions in buffer creation

This required a little refactoring to extract exception translation to a separate method

* Fix code formatting

* Fix "unused parameter" warning

* Refactor per review

* style: pre-commit fixes

* Address review comments

* Address review comments

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This commit is contained in:
Vasily Litvinov
2024-09-02 19:01:59 +03:00
committed by GitHub
parent 66c3774a64
commit aeda49ed0b
7 changed files with 108 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/test_buffers.py
View File

@@ -228,3 +228,10 @@ def test_buffer_docstring():
m.get_buffer_info.__doc__.strip()
== "get_buffer_info(arg0: Buffer) -> pybind11_tests.buffers.buffer_info"
)
def test_buffer_exception():
with pytest.raises(BufferError, match="Error getting buffer") as excinfo:
memoryview(m.BrokenMatrix(1, 1))
assert isinstance(excinfo.value.__cause__, RuntimeError)
assert "for context" in str(excinfo.value.__cause__)