mirror of
https://github.com/pybind/pybind11.git
synced 2026-03-14 20:27:47 +00:00
Make string conversion stricter (#695)
* Make string conversion stricter The string conversion logic added in PR #624 for all std::basic_strings was derived from the old std::wstring logic, but that was underused and turns out to have had a bug in accepting almost anything convertible to unicode, while the previous std::string logic was much stricter. This restores the previous std::string logic by only allowing actual unicode or string types. Fixes #685. * Added missing 'requires numpy' decorator (I forgot that the change to a global decorator here is in the not-yet-merged Eigen PR)
This commit is contained in:
committed by
Wenzel Jakob
parent
dd01665e5a
commit
ee2e5a5086
@@ -150,4 +150,9 @@ test_initializer numpy_array([](py::module &m) {
|
||||
"array_t<double>"_a=py::array_t<double>(o)
|
||||
);
|
||||
});
|
||||
|
||||
// Issue 685: ndarray shouldn't go to std::string overload
|
||||
sm.def("issue685", [](std::string) { return "string"; });
|
||||
sm.def("issue685", [](py::array) { return "array"; });
|
||||
sm.def("issue685", [](py::object) { return "other"; });
|
||||
});
|
||||
|
||||
Reference in New Issue
Block a user