Ralf W. Grosse-Kunstleve
|
ec557ff612
|
Backport non-functional test_class_sh_*.cpp changes from PR #5213: 1. To avoid compiler warnings for unused code in the unnamed namespace. 2. To avoid clang-format changes. (#5258)
|
2024-07-22 01:56:42 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
59ef5307ae
|
[smart_holder] Add gil_scoped_acquire to shared_ptr_trampoline_self_life_support ctor. (#4196)
* Add `gil_scoped_acquire` to `shared_ptr_trampoline_self_life_support` ctor.
* Add test exercising fix & validation that the fix is needed (i.e. this is BROKEN).
test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_std_make_shared_factory[pass_through_shd_ptr] PASSED [ 87%]
test_class_sh_trampoline_shared_ptr_cpp_arg.py::test_std_make_shared_factory[pass_through_shd_ptr_release_gil] FAILED [100%]
```
================================================================= FAILURES =================================================================
______________________________________ test_std_make_shared_factory[pass_through_shd_ptr_release_gil] ______________________________________
pass_through_func = <built-in method pass_through_shd_ptr_release_gil of PyCapsule object at 0x7f1b209707b0>
@pytest.mark.parametrize(
"pass_through_func", [m.pass_through_shd_ptr, m.pass_through_shd_ptr_release_gil]
)
def test_std_make_shared_factory(pass_through_func):
class PyChild(m.SpBase):
def __init__(self):
super().__init__(0)
obj = PyChild()
while True:
> assert pass_through_func(obj) is obj
E RuntimeError: NEEDED HERE: gil_scoped_acquire gil;
```
* Put back fix.
|
2022-10-07 12:24:49 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
05c8b9b7a8
|
Automatic pre-commit run --all-files and clang-tidy changes (NO manual changes).
|
2022-02-14 19:00:40 -08:00 |
|
Ralf W. Grosse-Kunstleve
|
52c3f4cc30
|
This was meant to be PR #3065: pure clang-format changes. NO manual changes. (#3073)
|
2021-07-02 16:51:24 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
e2108546e1
|
Adding unit tests: 2 x test_std_make_shared_factory
Completes unit test coverage for the changed code in smart_holder_type_casters.h.
|
2021-06-30 07:04:31 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
2eeac0c369
|
Applying clang-tidy fixes needed after merging PR #3051 (mostly automatically).
|
2021-06-22 13:38:30 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
8d1e0b3903
|
[smart_holder] clang-tidy fixes (related to recent clang-tidy changes on master). (#3053)
* clang-tidy fixes (related to recent clang-tidy changes on master).
* More clang-tidy fixes.
|
2021-06-21 12:40:10 -07:00 |
|
Ralf W. Grosse-Kunstleve
|
97a7fb722a
|
Porting/adapting Dustin's PR #2839 to smart_holder branch (#2886)
* WIP: test setup complete, AddInCppUniquePtr failing (reproduces PyCLIF smart_ptrs_test failure).
* Fully tested locally.
* Adding new tests to cmake file.
|
2021-03-03 17:58:42 -08:00 |
|