mirror of
https://github.com/pybind/pybind11.git
synced 2026-03-14 20:27:47 +00:00
* Pure `git merge --squash smart_holder` (no manual interventions). * Remove ubench/ directory. * Remove include/pybind11/smart_holder.h * [ci skip] smart_ptrs.rst updates [WIP/unfinished] * [ci skip] smart_ptrs.rst updates continued; also updating classes.rst, advanced/classes.rst * Remove README_smart_holder.rst * Restore original README.rst from master * [ci skip] Minimal change to README.rst, to leave a hint that this is pybind11v3 * [ci skip] Work in ChatGPT suggestions. * Change macro name to PYBIND11_RUN_TESTING_WITH_SMART_HOLDER_AS_DEFAULT_BUT_NEVER_USE_IN_PRODUCTION_PLEASE * Add a note pointing to the holder reinterpret_cast. * Incorporate suggestion by @virtuald: https://github.com/pybind/pybind11/pull/5542#discussion_r1967000989 * Systematically change most py::class_ to py::classh under docs/ * Remove references to README_smart_holder.rst This should have been part of commiteb550d03d3. * [ci skip] Fix minor oversight (``class_`` -> ``py::class_``) noticed by chance. * [ci skip] Resolve suggestion by @virtuald https://github.com/pybind/pybind11/pull/5542#discussion_r1969940605 * [ci skip] Apply suggestions by @timohl (thanks!) * https://github.com/pybind/pybind11/pull/5542#discussion_r1970714551 * https://github.com/pybind/pybind11/pull/5542#discussion_r1971315329 * https://github.com/pybind/pybind11/pull/5542#discussion_r1971322821 * Replace `classh : class_` inhertance with `using`, as suggested by @henryiii https://github.com/pybind/pybind11/pull/5542#issuecomment-2689034104 * Revert "Systematically change most py::class_ to py::classh under docs/" This reverts commitac9d31e13f. * docs: focus on py::smart_holder instead of py::classh Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> * Restore minor general fixes that got lost whenac9d31e13fwas reverted. * Remove `- smart_holder` from list of branches in all .github/workflows * Extend classh note to explain whitespace noise motivation. * Suggest `py::smart_holder` for "most situations for safety" * Add back PYBIND11_HAS_INTERNALS_WITH_SMART_HOLDER_SUPPORT This define was * introduced with https://github.com/pybind/pybind11/pull/5286 * removed with https://github.com/pybind/pybind11/pull/5531 It is has been in use here: *f02a2b7653/pybind11_protobuf/native_proto_caster.h (L89-L101)Currently pybind11 unit tests for the two holder caster backwards compatibility traits * `copyable_holder_caster_shared_ptr_with_smart_holder_support_enabled` * `move_only_holder_caster_unique_ptr_with_smart_holder_support_enabled` are missing. * Add py::trampoline_self_life_support to all trampoline examples under docs/. Address suggestion by @timohl: * https://github.com/pybind/pybind11/pull/5542#issuecomment-2686452062 Add to the "please think twice" note: the overhead for safety is likely in the noise. Also fix a two-fold inconsistency introduced by revert-commit1e646c91b4: 1. py::trampoline_self_life_support is mentioned in a note, but is missing in the example right before. 2. The section starting with To enable safely passing a ``std::unique_ptr`` to a trampoline object between is obsolete. * Fix whitespace accident (indentation) introduced with1e646c91b4Apparently the mis-indentation was introduced when resolving merge conflicts for what became1e646c91b4* WHITESPACE CHANGES ONLY in README.rst (list of people that made significant contributions) * Add Ethan Steinberg to list of people that made significant contributions (for completeness, unrelated to smart_holder work). * [ci skip] Add to list of people that made significant contributions: major and/or influential contributors to smart_holder branch * #2904 by @rhaschke was merged on Mar 16, 2021 * #3012 by @rhaschke was merged on May 28, 2021 * #3039 by @jakobandersen was merged on Jun 29, 2021 * #3048 by @Skylion007 was merged on Jun 18, 2021 * #3588 by @virtuald was merged on Jan 3, 2022 * #3633 by @wangxf123456 was merged on Jan 25, 2022 * #3635 by @virtuald was merged on Jan 26, 2022 * #3645 by @wangxf123456 was merged on Jan 25, 2022 * #3796 by @wangxf123456 was merged on Mar 10, 2022 * #3807 by @wangxf123456 was merged on Mar 18, 2022 * #3838 by @wangxf123456 was merged on Apr 15, 2022 * #3929 by @tomba was merged on May 7, 2022 * #4031 by @wangxf123456 was merged on Jun 27, 2022 * #4343 by @wangxf123456 was merged on Nov 18, 2022 * #4381 by @wangxf123456 was merged on Dec 5, 2022 * #4539 by @wangxf123456 was merged on Feb 28, 2023 * #4609 by @wangxf123456 was merged on Apr 6, 2023 * #4775 by @wangxf123456 was merged on Aug 3, 2023 * #4921 by @iwanders was merged on Nov 7, 2023 * #4924 by @iwanders was merged on Nov 6, 2023 * #5401 by @msimacek was merged on Oct 8, 2024 Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com> Co-authored-by: Ivor Wanders <iwanders@users.noreply.github.com> Co-authored-by: Jakob Lykke Andersen <Jakob@caput.dk> Co-authored-by: Michael Šimáček <michael.simacek@oracle.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Tomi Valkeinen <tomi.valkeinen@iki.fi> Co-authored-by: Xiaofei Wang <6218006+wangxf123456@users.noreply.github.com> --------- Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: Henry Schreiner <henryschreineriii@gmail.com> Co-authored-by: Aaron Gokaslan <aaronGokaslan@gmail.com> Co-authored-by: Dustin Spicuzza <dustin@virtualroadside.com> Co-authored-by: Ivor Wanders <iwanders@users.noreply.github.com> Co-authored-by: Jakob Lykke Andersen <Jakob@caput.dk> Co-authored-by: Michael Šimáček <michael.simacek@oracle.com> Co-authored-by: Robert Haschke <rhaschke@users.noreply.github.com> Co-authored-by: Tomi Valkeinen <tomi.valkeinen@iki.fi> Co-authored-by: Xiaofei Wang <6218006+wangxf123456@users.noreply.github.com>
248 lines
8.1 KiB
Python
248 lines
8.1 KiB
Python
from __future__ import annotations
|
|
|
|
import sys
|
|
import weakref
|
|
|
|
import pytest
|
|
|
|
import env
|
|
import pybind11_tests.class_sh_trampoline_shared_from_this as m
|
|
|
|
|
|
class PySft(m.Sft):
|
|
pass
|
|
|
|
|
|
def test_release_and_shared_from_this():
|
|
# Exercises the most direct path from building a shared_from_this-visible
|
|
# shared_ptr to calling shared_from_this.
|
|
obj = PySft("PySft")
|
|
assert obj.history == "PySft"
|
|
assert m.use_count(obj) == 1
|
|
assert m.pass_shared_ptr(obj) == 2
|
|
assert obj.history == "PySft_PassSharedPtr"
|
|
assert m.use_count(obj) == 1
|
|
assert m.pass_shared_ptr(obj) == 2
|
|
assert obj.history == "PySft_PassSharedPtr_PassSharedPtr"
|
|
assert m.use_count(obj) == 1
|
|
|
|
|
|
def test_release_and_shared_from_this_leak():
|
|
obj = PySft("")
|
|
while True:
|
|
m.pass_shared_ptr(obj)
|
|
assert not obj.history
|
|
assert m.use_count(obj) == 1
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
def test_release_and_stash():
|
|
# Exercises correct functioning of guarded_delete weak_ptr.
|
|
obj = PySft("PySft")
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
stash1.Add(obj)
|
|
exp_hist = "PySft_Stash1Add"
|
|
assert obj.history == exp_hist
|
|
assert m.use_count(obj) == 2
|
|
assert stash1.history(0) == exp_hist
|
|
assert stash1.use_count(0) == 1
|
|
assert m.pass_shared_ptr(obj) == 3
|
|
exp_hist += "_PassSharedPtr"
|
|
assert obj.history == exp_hist
|
|
assert m.use_count(obj) == 2
|
|
assert stash1.history(0) == exp_hist
|
|
assert stash1.use_count(0) == 1
|
|
stash2 = m.SftSharedPtrStash(2)
|
|
stash2.Add(obj)
|
|
exp_hist += "_Stash2Add"
|
|
assert obj.history == exp_hist
|
|
assert m.use_count(obj) == 3
|
|
assert stash2.history(0) == exp_hist
|
|
assert stash2.use_count(0) == 2
|
|
stash2.Add(obj)
|
|
exp_hist += "_Stash2Add"
|
|
assert obj.history == exp_hist
|
|
assert m.use_count(obj) == 4
|
|
assert stash1.history(0) == exp_hist
|
|
assert stash1.use_count(0) == 3
|
|
assert stash2.history(0) == exp_hist
|
|
assert stash2.use_count(0) == 3
|
|
assert stash2.history(1) == exp_hist
|
|
assert stash2.use_count(1) == 3
|
|
del obj
|
|
assert stash2.history(0) == exp_hist
|
|
assert stash2.use_count(0) == 3
|
|
assert stash2.history(1) == exp_hist
|
|
assert stash2.use_count(1) == 3
|
|
stash2.Clear()
|
|
assert stash1.history(0) == exp_hist
|
|
assert stash1.use_count(0) == 1
|
|
|
|
|
|
def test_release_and_stash_leak():
|
|
obj = PySft("")
|
|
while True:
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
stash1.Add(obj)
|
|
assert not obj.history
|
|
assert m.use_count(obj) == 2
|
|
assert stash1.use_count(0) == 1
|
|
stash1.Add(obj)
|
|
assert not obj.history
|
|
assert m.use_count(obj) == 3
|
|
assert stash1.use_count(0) == 2
|
|
assert stash1.use_count(1) == 2
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
def test_release_and_stash_via_shared_from_this():
|
|
# Exercises that the smart_holder vptr is invisible to the shared_from_this mechanism.
|
|
obj = PySft("PySft")
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
stash1.AddSharedFromThis(obj)
|
|
assert str(exc_info.value) == "bad_weak_ptr"
|
|
stash1.Add(obj)
|
|
assert obj.history == "PySft_Stash1Add"
|
|
assert stash1.use_count(0) == 1
|
|
stash1.AddSharedFromThis(obj)
|
|
assert obj.history == "PySft_Stash1Add_Stash1AddSharedFromThis"
|
|
assert stash1.use_count(0) == 2
|
|
assert stash1.use_count(1) == 2
|
|
|
|
|
|
def test_release_and_stash_via_shared_from_this_leak():
|
|
obj = PySft("")
|
|
while True:
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
stash1.AddSharedFromThis(obj)
|
|
assert str(exc_info.value) == "bad_weak_ptr"
|
|
stash1.Add(obj)
|
|
assert not obj.history
|
|
assert stash1.use_count(0) == 1
|
|
stash1.AddSharedFromThis(obj)
|
|
assert not obj.history
|
|
assert stash1.use_count(0) == 2
|
|
assert stash1.use_count(1) == 2
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
def test_pass_released_shared_ptr_as_unique_ptr():
|
|
# Exercises that returning a unique_ptr fails while a shared_from_this
|
|
# visible shared_ptr exists.
|
|
obj = PySft("PySft")
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
stash1.Add(obj) # Releases shared_ptr to C++.
|
|
assert m.pass_unique_ptr_cref(obj) == "PySft_Stash1Add"
|
|
assert obj.history == "PySft_Stash1Add"
|
|
with pytest.raises(ValueError) as exc_info:
|
|
m.pass_unique_ptr_rref(obj)
|
|
assert str(exc_info.value) == (
|
|
"Python instance is currently owned by a std::shared_ptr."
|
|
)
|
|
assert obj.history == "PySft_Stash1Add"
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"make_f",
|
|
[
|
|
m.make_pure_cpp_sft_raw_ptr,
|
|
m.make_pure_cpp_sft_unq_ptr,
|
|
m.make_pure_cpp_sft_shd_ptr,
|
|
],
|
|
)
|
|
def test_pure_cpp_sft_raw_ptr(make_f):
|
|
# Exercises void_cast_raw_ptr logic for different situations.
|
|
obj = make_f("PureCppSft")
|
|
assert m.pass_shared_ptr(obj) == 3
|
|
assert obj.history == "PureCppSft_PassSharedPtr"
|
|
obj = make_f("PureCppSft")
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
stash1.AddSharedFromThis(obj)
|
|
assert obj.history == "PureCppSft_Stash1AddSharedFromThis"
|
|
|
|
|
|
def test_multiple_registered_instances_for_same_pointee():
|
|
obj0 = PySft("PySft")
|
|
obj0.attachment_in_dict = "Obj0"
|
|
assert m.pass_through_shd_ptr(obj0) is obj0
|
|
while True:
|
|
obj = m.Sft(obj0)
|
|
assert obj is not obj0
|
|
obj_pt = m.pass_through_shd_ptr(obj)
|
|
# Unpredictable! Because registered_instances is as std::unordered_multimap.
|
|
assert obj_pt is obj0 or obj_pt is obj
|
|
# Multiple registered_instances for the same pointee can lead to unpredictable results:
|
|
if obj_pt is obj0:
|
|
assert obj_pt.attachment_in_dict == "Obj0"
|
|
else:
|
|
assert not hasattr(obj_pt, "attachment_in_dict")
|
|
assert obj0.history == "PySft"
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
def test_multiple_registered_instances_for_same_pointee_leak():
|
|
obj0 = PySft("")
|
|
while True:
|
|
stash1 = m.SftSharedPtrStash(1)
|
|
stash1.Add(m.Sft(obj0))
|
|
assert stash1.use_count(0) == 1
|
|
stash1.Add(m.Sft(obj0))
|
|
assert stash1.use_count(0) == 1
|
|
assert stash1.use_count(1) == 1
|
|
assert not obj0.history
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
def test_multiple_registered_instances_for_same_pointee_recursive():
|
|
while True:
|
|
obj0 = PySft("PySft")
|
|
if not env.PYPY:
|
|
obj0_wr = weakref.ref(obj0)
|
|
obj = obj0
|
|
# This loop creates a chain of instances linked by shared_ptrs.
|
|
for _ in range(10):
|
|
obj_next = m.Sft(obj)
|
|
assert obj_next is not obj
|
|
obj = obj_next
|
|
del obj_next
|
|
assert obj.history == "PySft"
|
|
del obj0
|
|
if not env.PYPY and not env.GRAALPY:
|
|
assert obj0_wr() is not None
|
|
del obj # This releases the chain recursively.
|
|
if not env.PYPY and not env.GRAALPY:
|
|
assert obj0_wr() is None
|
|
break # Comment out for manual leak checking (use `top` command).
|
|
|
|
|
|
# As of 2021-07-10 the pybind11 GitHub Actions valgrind build uses Python 3.9.
|
|
WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 = env.LINUX and sys.version_info == (3, 9)
|
|
|
|
|
|
def test_std_make_shared_factory():
|
|
class PySftMakeShared(m.Sft):
|
|
def __init__(self, history):
|
|
super().__init__(history, 0)
|
|
|
|
obj = PySftMakeShared("PySftMakeShared")
|
|
assert obj.history == "PySftMakeShared"
|
|
if WORKAROUND_ENABLING_ROLLBACK_OF_PR3068:
|
|
try:
|
|
m.pass_through_shd_ptr(obj)
|
|
except RuntimeError as e:
|
|
str_exc_info_value = str(e)
|
|
else:
|
|
str_exc_info_value = "RuntimeError NOT RAISED"
|
|
else:
|
|
with pytest.raises(RuntimeError) as exc_info:
|
|
m.pass_through_shd_ptr(obj)
|
|
str_exc_info_value = str(exc_info.value)
|
|
assert (
|
|
str_exc_info_value
|
|
== "smart_holder_type_casters load_as_shared_ptr failure: not implemented:"
|
|
" trampoline-self-life-support for external shared_ptr to type inheriting"
|
|
" from std::enable_shared_from_this."
|
|
)
|