[PR #111] [MERGED] fix: online-only names, word-start kb search, checksummed ffmpeg down… #131

New issue

Closed

opened 2026-10-15 20:53:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:53:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/111
Author: @newachievement
Created: 10/6/2026
Status: ✅ Merged
Merged: 10/7/2026
Merged by: @rehan-remade

Base: main ← Head: claude/upbeat-ride-1tz53p

📝 Commits (2)

f5c4d6d fix: online-only names, word-start kb search, checksummed ffmpeg download
74a4cd5 Merge main into claude/upbeat-ride-1tz53p

📊 Changes

4 files changed (+115 additions, -11 deletions)

View changed files

📝 tests/test_um.py (+49 -0)
📝 um/kb.py (+10 -4)
📝 um/scan.py (+20 -4)
📝 um/win.py (+36 -3)

📄 Description

…load

scan: match ONLINE_ONLY against the whole game name instead of substrings. "rust" flagged Rusty Lake, "battlefield" flagged Battlefield 1942 and "call of duty" flagged the 2009 Modern Warfare 2, each with a "stop" warning.
kb search: terms must start a word, so "rust" no longer finds "trust" or "frustum".
win setup: check the ffmpeg zip's SHA-256 against the build's published checksums.sha256 (or a UM_FFMPEG_SHA256 pin) before extracting; a mismatch deletes the download.

Claude-Session: https://claude.ai/code/session_01RavJ1bZ9WUZSKc6qp4QDVb

What:

Checklist

um kb check passes (field notes) / uv run --with pytest pytest -q tests passes (code)
um kb index regenerated (field notes)
no game files, extracted assets, decompiled code dumps or secrets
nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks
versions, verification and what was NOT verified are written down
authored by (agent + model / human):

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/111 **Author:** [@newachievement](https://github.com/newachievement) **Created:** 10/6/2026 **Status:** ✅ Merged **Merged:** 10/7/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `claude/upbeat-ride-1tz53p` --- ### 📝 Commits (2) - [`f5c4d6d`](https://github.com/rehan-remade/universal-modder/commit/f5c4d6dff1160e09c8291cac60e5a949cfbb3e0c) fix: online-only names, word-start kb search, checksummed ffmpeg download - [`74a4cd5`](https://github.com/rehan-remade/universal-modder/commit/74a4cd5de5b297db6a50228ed5e15e9086d29a6d) Merge main into claude/upbeat-ride-1tz53p ### 📊 Changes **4 files changed** (+115 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_um.py` (+49 -0) 📝 `um/kb.py` (+10 -4) 📝 `um/scan.py` (+20 -4) 📝 `um/win.py` (+36 -3) </details> ### 📄 Description …load - scan: match ONLINE_ONLY against the whole game name instead of substrings. "rust" flagged Rusty Lake, "battlefield" flagged Battlefield 1942 and "call of duty" flagged the 2009 Modern Warfare 2, each with a "stop" warning. - kb search: terms must start a word, so "rust" no longer finds "trust" or "frustum". - win setup: check the ffmpeg zip's SHA-256 against the build's published checksums.sha256 (or a UM_FFMPEG_SHA256 pin) before extracting; a mismatch deletes the download. Claude-Session: https://claude.ai/code/session_01RavJ1bZ9WUZSKc6qp4QDVb  **What:**  **Checklist** - [ ] `um kb check` passes (field notes) / `uv run --with pytest pytest -q tests` passes (code) - [ ] `um kb index` regenerated (field notes) - [ ] no game files, extracted assets, decompiled code dumps or secrets - [ ] nothing that cheats other players or bypasses anti-cheat / DRM / ownership checks - [ ] versions, verification and what was NOT verified are written down - [ ] authored by (agent + model / human):  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:53:39 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

rehan-remade/universal-modder#131

No description provided.

Rows
Columns