[PR #198] [MERGED] examples/gta5: install.sh --remove keeps a ReShade.ini it didn't create; root .gitattributes #200

New issue

Closed

opened 2026-10-15 20:54:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:54:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/198
Author: @TheFlano23
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @rehan-remade

Base: main ← Head: fix/gta5-install-reshade-ini-marker

📝 Commits (3)

c3e5c9c examples/gta5: install.sh --remove keeps a ReShade.ini it didn't create; root .gitattributes keeps scripts LF
5629300 examples/gta5: docs match the ReShade.ini marker; .gitattributes also pins bin/um
c40e2ee Merge remote-tracking branch 'origin/main' into land/pr-198

📊 Changes

5 files changed (+23 additions, -11 deletions)

View changed files

➕ .gitattributes (+4 -0)
📝 examples/minecraft-gta5-passthrough/README.md (+3 -1)
📝 examples/minecraft-gta5-passthrough/gta/install.sh (+4 -1)
📝 knowledge/games/gta-v/minecraft-passthrough.md (+9 -7)
📝 knowledge/techniques/installers-load-order-and-loaded-code-checks.md (+3 -2)

📄 Description

Follow-up to #172, as suggested in its review.

examples/minecraft-gta5-passthrough/gta/install.sh: --remove no longer deletes a ReShade.ini the user had before installing.

ReShade.ini is dropped from the removal list.
When install creates ReShade.ini, it also writes a marker file, .mcpassthrough_reshade_ini.
--remove deletes ReShade.ini (and the marker) only when the marker is there.

Nothing else in the script changes. In particular the WSL paths and the BUILD default are untouched.

Root .gitattributes: pins *.sh and gradlew to LF, so a Windows checkout with core.autocrlf can still run the scripts from WSL (gotcha 25 in the note).

Tested under WSL (Ubuntu 26.04) against a throwaway folder containing only a dummy GTA5.exe:

fresh install, then --remove: only GTA5.exe is left, and the ReShade.ini that install created is gone;
with a pre-existing ReShade.ini: after install and --remove, it is still there, unchanged.

On the second PC, the real GTA folder was installed with the same marker logic (the marker was written), but --remove hasn't been run there.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/198 **Author:** [@TheFlano23](https://github.com/TheFlano23) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `fix/gta5-install-reshade-ini-marker` --- ### 📝 Commits (3) - [`c3e5c9c`](https://github.com/rehan-remade/universal-modder/commit/c3e5c9ce1f4dc6322b61ba9b9f94bc86243b6d25) examples/gta5: install.sh --remove keeps a ReShade.ini it didn't create; root .gitattributes keeps scripts LF - [`5629300`](https://github.com/rehan-remade/universal-modder/commit/5629300485696bca31b41ec2cdced86d22625eff) examples/gta5: docs match the ReShade.ini marker; .gitattributes also pins bin/um - [`c40e2ee`](https://github.com/rehan-remade/universal-modder/commit/c40e2ee67f05441bd37e22f28ae684c70c48adc2) Merge remote-tracking branch 'origin/main' into land/pr-198 ### 📊 Changes **5 files changed** (+23 additions, -11 deletions) <details> <summary>View changed files</summary> ➕ `.gitattributes` (+4 -0) 📝 `examples/minecraft-gta5-passthrough/README.md` (+3 -1) 📝 `examples/minecraft-gta5-passthrough/gta/install.sh` (+4 -1) 📝 `knowledge/games/gta-v/minecraft-passthrough.md` (+9 -7) 📝 `knowledge/techniques/installers-load-order-and-loaded-code-checks.md` (+3 -2) </details> ### 📄 Description Follow-up to #172, as suggested in its review. **`examples/minecraft-gta5-passthrough/gta/install.sh`:** `--remove` no longer deletes a `ReShade.ini` the user had before installing. - `ReShade.ini` is dropped from the removal list. - When install creates `ReShade.ini`, it also writes a marker file, `.mcpassthrough_reshade_ini`. - `--remove` deletes `ReShade.ini` (and the marker) only when the marker is there. Nothing else in the script changes. In particular the WSL paths and the `BUILD` default are untouched. **Root `.gitattributes`:** pins `*.sh` and `gradlew` to LF, so a Windows checkout with `core.autocrlf` can still run the scripts from WSL (gotcha 25 in the note). **Tested** under WSL (Ubuntu 26.04) against a throwaway folder containing only a dummy `GTA5.exe`: - fresh install, then `--remove`: only `GTA5.exe` is left, and the `ReShade.ini` that install created is gone; - with a pre-existing `ReShade.ini`: after install and `--remove`, it is still there, unchanged. On the second PC, the real GTA folder was installed with the same marker logic (the marker was written), but `--remove` hasn't been run there. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:54:17 +00:00