[PR #259] [MERGED] um video: read EDLs as UTF-8, and let the theme set fonts for non-Latin titles #258

New issue

Closed

opened 2026-10-15 20:54:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-15 20:54:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/rehan-remade/universal-modder/pull/259
Author: @rehan-remade
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @rehan-remade

Base: main ← Head: fix/video-utf8

📝 Commits (1)

4bdb854 um video: read EDLs as UTF-8, and let the theme set fonts for non-Latin titles

📊 Changes

2 files changed (+23 additions, -4 deletions)

View changed files

📝 tests/test_um.py (+12 -0)
📝 um/video.py (+11 -4)

📄 Description

Found while reviewing #221 (its Gotcha 35): um video compile read the EDL with the locale encoding, so a UTF-8 EDL with Russian titles broke on Windows, and the bundled Space Grotesk has no Cyrillic glyphs anyway.

EDLs and the recorder's timing json are read as UTF-8.
The EDL theme takes optional title_font / body_font / mono_font paths (relative to the EDL), which replace the bundled fonts for that edit. The help text says when to use them.
test_video_theme_font_override renders a Cyrillic hook title with an override and checks the override is cleared afterwards.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/rehan-remade/universal-modder/pull/259 **Author:** [@rehan-remade](https://github.com/rehan-remade) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@rehan-remade](https://github.com/rehan-remade) **Base:** `main` ← **Head:** `fix/video-utf8` --- ### 📝 Commits (1) - [`4bdb854`](https://github.com/rehan-remade/universal-modder/commit/4bdb8542aa186559c1a0b05db40f62b964b216a1) um video: read EDLs as UTF-8, and let the theme set fonts for non-Latin titles ### 📊 Changes **2 files changed** (+23 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/test_um.py` (+12 -0) 📝 `um/video.py` (+11 -4) </details> ### 📄 Description Found while reviewing #221 (its Gotcha 35): `um video compile` read the EDL with the locale encoding, so a UTF-8 EDL with Russian titles broke on Windows, and the bundled Space Grotesk has no Cyrillic glyphs anyway. - EDLs and the recorder's timing json are read as UTF-8. - The EDL theme takes optional `title_font` / `body_font` / `mono_font` paths (relative to the EDL), which replace the bundled fonts for that edit. The help text says when to use them. - `test_video_theme_font_override` renders a Cyrillic hook title with an override and checks the override is cleared afterwards. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-15 20:54:52 +00:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

rehan-remade/universal-modder#258

No description provided.

Rows
Columns