[PR #150] [CLOSED] Implemented #137 - Manual execute single topic/tracker shouldn't reset timeout #368

New issue

Closed

opened 2026-10-13 19:56:39 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-13 19:56:39 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/werwolfby/monitorrent/pull/150
Author: @vlad-nikityuk
Created: 10/31/2016
Status: ❌ Closed

Base: develop ← Head: issues/137

📝 Commits (5)

c3034a3 Added test to emulate the case for "Manual execute single topic/tracker shouldn't reset timeout for whole execute".
e9cfecf Implementation using threading timer.
35cb76c Moved timer implementation to separate module.
5b0c7d5 Fixed compatibility with python 3.5
c20a6bb Fixed codacy warnings.

📊 Changes

4 files changed (+198 additions, -68 deletions)

View changed files

📝 monitorrent/engine.py (+55 -16)
➕ monitorrent/utils/timers.py (+11 -0)
📝 tests/test_engine.py (+92 -52)
➕ tests/utils/test_timers.py (+40 -0)

📄 Description

#137 Implemented timer via separate thread pushing messages to worker's priority queue.
Added two types of message:

stop_message that has the highest priority
run_message that can be parametrized with list of ids

Added unit tests just to engine.py.
Not sure if api tests are needed here, will add them if needed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/werwolfby/monitorrent/pull/150 **Author:** [@vlad-nikityuk](https://github.com/vlad-nikityuk) **Created:** 10/31/2016 **Status:** ❌ Closed **Base:** `develop` ← **Head:** `issues/137` --- ### 📝 Commits (5) - [`c3034a3`](https://github.com/werwolfby/monitorrent/commit/c3034a39b147a7cb3c8a67b2c1109cb5611d73ea) Added test to emulate the case for "Manual execute single topic/tracker shouldn't reset timeout for whole execute". - [`e9cfecf`](https://github.com/werwolfby/monitorrent/commit/e9cfecf230ac3e88c488ed7add3999add84f4239) Implementation using threading timer. - [`35cb76c`](https://github.com/werwolfby/monitorrent/commit/35cb76cbc0162386037577f53bfcd27db62e10dc) Moved timer implementation to separate module. - [`5b0c7d5`](https://github.com/werwolfby/monitorrent/commit/5b0c7d5196c5289d71a814e930e062636f2ccd61) Fixed compatibility with python 3.5 - [`c20a6bb`](https://github.com/werwolfby/monitorrent/commit/c20a6bbbfb2c2abe3f544b6ae1cab1539950af83) Fixed codacy warnings. ### 📊 Changes **4 files changed** (+198 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `monitorrent/engine.py` (+55 -16) ➕ `monitorrent/utils/timers.py` (+11 -0) 📝 `tests/test_engine.py` (+92 -52) ➕ `tests/utils/test_timers.py` (+40 -0) </details> ### 📄 Description #137 Implemented timer via separate thread pushing messages to worker's priority queue. Added two types of message: - stop_message that has the highest priority - run_message that can be parametrized with list of ids Added unit tests just to `engine.py`. Not sure if api tests are needed here, will add them if needed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-13 19:56:39 +00:00