[PR #157] [MERGED] fix: resolve all TypeScript lint errors for tsgo compatibility #157

New issue

Closed

opened 2026-10-27 21:10:07 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:07 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/157
Author: @comfy-pr-bot
Created: 2/17/2026
Status: ✅ Merged
Merged: 2/18/2026
Merged by: @comfy-pr-bot

Base: main ← Head: sno-fix-lint-2026-02-17

📝 Commits (1)

210e486 fix: resolve all TypeScript lint errors for tsgo compatibility

📊 Changes

62 files changed (+411 additions, -297 deletions)

View changed files

📝 app/(dashboard)/repos/page.tsx (+6 -6)
📝 app/(dashboard)/rules/page.tsx (+4 -4)
📝 app/api/router.ts (+3 -18)
📝 app/api/webhook/github/route.spec.ts (+4 -2)
📝 app/tasks/gh-design/GithubDesignTaskMetaEditor.tsx (+1 -1)
📝 app/tasks/gh-priority-sync/index.ts (+16 -8)
📝 bot/WorkingTasksManager.spec.ts (+40 -16)
📝 bot/cli.ts (+3 -2)
📝 bot/code/issue-search.ts (+1 -1)
📝 bot/code/prbot.ts (+1 -0)
📝 bot/codesearch-ai-wip.ts (+24 -14)
📝 bot/notion/search.ts (+12 -6)
📝 bot/registry/search.ts (+2 -2)
📝 bot/slack-bolt.ts (+22 -10)
📝 bot/slack-bot.ts (+2 -1)
📝 bot/slack/file.ts (+21 -12)
📝 bot/slack/msg-read-thread.ts (+3 -3)
📝 bot/slack/stream.ts (+1 -0)
📝 bot/templateLoader.ts (+2 -2)
📝 bot/utils/filterDebugMessages.ts (+1 -1)

...and 42 more files

📄 Description

Summary

Fix type errors across 60+ files to pass strict tsgo (TypeScript native Go compiler) type checking
Replace incorrect as any casts and type annotations with proper as unknown as T patterns
Fix Slack SDK type issues: FileElement/Attachment/Reaction lack index signatures
Fix DeepAsyncWrapper type in slackCached.ts to use infer instead of unknown[] for callable matching
Fix spread type errors: replace ...(cond && obj) pattern with ...(cond ? obj : {})
Fix tRPC router output type mismatch and Notion discriminated union property access

Test plan

tsgo reports 0 errors
oxlint --fix passes with 0 errors (213 warnings are pre-existing)
oxfmt --write formatting applied

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/157 **Author:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Created:** 2/17/2026 **Status:** ✅ Merged **Merged:** 2/18/2026 **Merged by:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Base:** `main` ← **Head:** `sno-fix-lint-2026-02-17` --- ### 📝 Commits (1) - [`210e486`](https://github.com/Comfy-Org/Comfy-PR/commit/210e486bafcbec9eeb4fd8cdeea29a09fb9e54b1) fix: resolve all TypeScript lint errors for tsgo compatibility ### 📊 Changes **62 files changed** (+411 additions, -297 deletions) <details> <summary>View changed files</summary> 📝 `app/(dashboard)/repos/page.tsx` (+6 -6) 📝 `app/(dashboard)/rules/page.tsx` (+4 -4) 📝 `app/api/router.ts` (+3 -18) 📝 `app/api/webhook/github/route.spec.ts` (+4 -2) 📝 `app/tasks/gh-design/GithubDesignTaskMetaEditor.tsx` (+1 -1) 📝 `app/tasks/gh-priority-sync/index.ts` (+16 -8) 📝 `bot/WorkingTasksManager.spec.ts` (+40 -16) 📝 `bot/cli.ts` (+3 -2) 📝 `bot/code/issue-search.ts` (+1 -1) 📝 `bot/code/prbot.ts` (+1 -0) 📝 `bot/codesearch-ai-wip.ts` (+24 -14) 📝 `bot/notion/search.ts` (+12 -6) 📝 `bot/registry/search.ts` (+2 -2) 📝 `bot/slack-bolt.ts` (+22 -10) 📝 `bot/slack-bot.ts` (+2 -1) 📝 `bot/slack/file.ts` (+21 -12) 📝 `bot/slack/msg-read-thread.ts` (+3 -3) 📝 `bot/slack/stream.ts` (+1 -0) 📝 `bot/templateLoader.ts` (+2 -2) 📝 `bot/utils/filterDebugMessages.ts` (+1 -1) _...and 42 more files_ </details> ### 📄 Description ## Summary - Fix type errors across 60+ files to pass strict `tsgo` (TypeScript native Go compiler) type checking - Replace incorrect `as any` casts and type annotations with proper `as unknown as T` patterns - Fix Slack SDK type issues: `FileElement`/`Attachment`/`Reaction` lack index signatures - Fix `DeepAsyncWrapper` type in `slackCached.ts` to use `infer` instead of `unknown[]` for callable matching - Fix spread type errors: replace `...(cond && obj)` pattern with `...(cond ? obj : {})` - Fix tRPC router output type mismatch and Notion discriminated union property access ## Test plan - [x] `tsgo` reports 0 errors - [x] `oxlint --fix` passes with 0 errors (213 warnings are pre-existing) - [x] `oxfmt --write` formatting applied 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:10:07 +00:00