Comfy-Org/Comfy-PR
1
0
Fork 0
mirror of https://github.com/Comfy-Org/Comfy-PR.git synced 2026-11-04 23:37:33 +00:00
Code Issues 18 Projects Packages Wiki Activity

[PR #172] ci: auto lint/format fix in CI + test with bad formatting #172

New issue
Open
opened 2026-10-27 21:10:15 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-27 21:10:15 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/172
Author: @snomiao
Created: 2/19/2026
Status: 🔄 Open

Base: main ← Head: sno-fix-msg-post-2026-02-18

📝 Commits (10+)

  • 47eea8c ci: add auto lint/format fix and commit to test workflow
  • 7a98c87 fix: checkout PR branch ref to allow git push from CI
  • ad4840d Merge branch 'main' into sno-fix-msg-post-2026-02-18
  • b706f85 feat(backport): improve backport notifications with persistent warnings and author tagging (#179)
  • 85a49d1 refactor(backport): rename labels to no-backport-needed[-cloud|-core] (#183)
  • 4e4273a Merge branch 'sno-fix-msg-post-2026-02-18' of github.com:Comfy-Org/Comfy-PR into sno-fix-msg-post-2026-02-18
  • 28532aa fix(ci): skip husky pre-commit hook in CI auto-commit
  • 5fbc754 feat: merge sno-bot improvements to main (#184)
  • faa2113 Merge branch 'sno-fix-msg-post-2026-02-18' of https://github.com/Comfy-Org/Comfy-PR into sno-fix-msg-post-2026-02-18
  • d2e72e0 fix(ci): skip CI on auto-fix commit and guard against fork PRs

📊 Changes

32 files changed (+1673 additions, -260 deletions)

View changed files

➕ .bot/skills/video-read/SKILL.md (+69 -0)
➕ .claude/skills/video-read/SKILL.md (+69 -0)
📝 .github/workflows/test.yaml (+17 -1)
📝 .gitignore (+1 -0)
📝 .husky/pre-commit (+3 -3)
📝 app/tasks/gh-desktop-release-notification/index.spec.ts (+19 -17)
📝 app/tasks/gh-frontend-backport-checker/index.spec.ts (+484 -3)
📝 app/tasks/gh-frontend-backport-checker/index.ts (+390 -116)
📝 app/tasks/gh-issue-transfer-comfyui-to-frontend/index.spec.ts (+5 -3)
📝 app/tasks/gh-issue-transfer-comfyui-to-workflow_templates/index.spec.ts (+6 -1)
📝 app/tasks/gh-issue-transfer-frontend-to-comfyui/index.spec.ts (+17 -23)
📝 app/tasks/gh-priority-sync/index.spec.ts (+9 -1)
📝 bot/cli.ts (+98 -2)
📝 bot/code/prbot.ts (+1 -2)
📝 bot/slack-bolt.ts (+1 -6)
📝 bot/slack-bot.ts (+167 -35)
📝 bot/utils/filterDebugMessages.ts (+0 -1)
📝 bun.lock (+4 -1)
📝 lib/slack/msg-read-nearby.ts (+3 -0)
📝 lib/slack/msg-read-recent.ts (+2 -0)

...and 12 more files

📄 Description

Summary

  • Adds oxlint --fix and oxfmt --write to CI, auto-committing any fixes back to the branch
  • Intentionally bad formatting in lib/slack/index.ts to verify the auto-fix works

Test plan

  • CI should detect unformatted code and commit a fix automatically

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/172 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 2/19/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `sno-fix-msg-post-2026-02-18` --- ### 📝 Commits (10+) - [`47eea8c`](https://github.com/Comfy-Org/Comfy-PR/commit/47eea8cd4c68f5e31aeb557ec4a00839d44fc69d) ci: add auto lint/format fix and commit to test workflow - [`7a98c87`](https://github.com/Comfy-Org/Comfy-PR/commit/7a98c873672c9a09629f32e867611c1fabdebe4e) fix: checkout PR branch ref to allow git push from CI - [`ad4840d`](https://github.com/Comfy-Org/Comfy-PR/commit/ad4840dc1ef597d67fa4c0e21b8177e8888e4f6f) Merge branch 'main' into sno-fix-msg-post-2026-02-18 - [`b706f85`](https://github.com/Comfy-Org/Comfy-PR/commit/b706f85c9c58edcbe4c5cd595ce41362d02e47d8) feat(backport): improve backport notifications with persistent warnings and author tagging (#179) - [`85a49d1`](https://github.com/Comfy-Org/Comfy-PR/commit/85a49d18eb2ef40b0864dda63e64f208c7e85655) refactor(backport): rename labels to no-backport-needed[-cloud|-core] (#183) - [`4e4273a`](https://github.com/Comfy-Org/Comfy-PR/commit/4e4273ae82dd9c3fb8afb478f336e26ccab71bc9) Merge branch 'sno-fix-msg-post-2026-02-18' of github.com:Comfy-Org/Comfy-PR into sno-fix-msg-post-2026-02-18 - [`28532aa`](https://github.com/Comfy-Org/Comfy-PR/commit/28532aa327087945fba2f33798ccb4a037c6520d) fix(ci): skip husky pre-commit hook in CI auto-commit - [`5fbc754`](https://github.com/Comfy-Org/Comfy-PR/commit/5fbc7543b5ecda57afba4e642989e48a7cb6c4aa) feat: merge sno-bot improvements to main (#184) - [`faa2113`](https://github.com/Comfy-Org/Comfy-PR/commit/faa21137746e659b5e642b0cdea74aa672204a15) Merge branch 'sno-fix-msg-post-2026-02-18' of https://github.com/Comfy-Org/Comfy-PR into sno-fix-msg-post-2026-02-18 - [`d2e72e0`](https://github.com/Comfy-Org/Comfy-PR/commit/d2e72e05f4d84896f95c76185b523cd76777ef56) fix(ci): skip CI on auto-fix commit and guard against fork PRs ### 📊 Changes **32 files changed** (+1673 additions, -260 deletions) <details> <summary>View changed files</summary> ➕ `.bot/skills/video-read/SKILL.md` (+69 -0) ➕ `.claude/skills/video-read/SKILL.md` (+69 -0) 📝 `.github/workflows/test.yaml` (+17 -1) 📝 `.gitignore` (+1 -0) 📝 `.husky/pre-commit` (+3 -3) 📝 `app/tasks/gh-desktop-release-notification/index.spec.ts` (+19 -17) 📝 `app/tasks/gh-frontend-backport-checker/index.spec.ts` (+484 -3) 📝 `app/tasks/gh-frontend-backport-checker/index.ts` (+390 -116) 📝 `app/tasks/gh-issue-transfer-comfyui-to-frontend/index.spec.ts` (+5 -3) 📝 `app/tasks/gh-issue-transfer-comfyui-to-workflow_templates/index.spec.ts` (+6 -1) 📝 `app/tasks/gh-issue-transfer-frontend-to-comfyui/index.spec.ts` (+17 -23) 📝 `app/tasks/gh-priority-sync/index.spec.ts` (+9 -1) 📝 `bot/cli.ts` (+98 -2) 📝 `bot/code/prbot.ts` (+1 -2) 📝 `bot/slack-bolt.ts` (+1 -6) 📝 `bot/slack-bot.ts` (+167 -35) 📝 `bot/utils/filterDebugMessages.ts` (+0 -1) 📝 `bun.lock` (+4 -1) 📝 `lib/slack/msg-read-nearby.ts` (+3 -0) 📝 `lib/slack/msg-read-recent.ts` (+2 -0) _...and 12 more files_ </details> ### 📄 Description ## Summary - Adds `oxlint --fix` and `oxfmt --write` to CI, auto-committing any fixes back to the branch - Intentionally bad formatting in `lib/slack/index.ts` to verify the auto-fix works ## Test plan - [ ] CI should detect unformatted code and commit a fix automatically --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/release-tagger-branch-cut
matt/be-3554-claude-md-shim
cb__backport-checker-released-status
fix/gh-combined-tasks-concurrency-guard
sno-coreping-groupby-author
sno-bot
sno/fix-notion-cursor-priority-sync
fix/gh-design-self-review
fix/backport-checker-skip-non-main-releases
refactor/merge-bot-cli-into-index
fix/flaky-workflow-templates-test
sno-release
sno-qabot
sno-fix-test-2025-11-05
sno-fix-msg-post-2026-02-18
copilot/sub-pr-179-another-one
copilot/sub-pr-179-again
copilot/sub-pr-179
sno-perf-2026-03-01
sno-test-evidence
sno-fix-repolist-endpoint
sno-priorities-backsync
fix/housekeeping
sno-cloudrun
pr/oxlint-type-safety
feature/backport-label-emoji
sno-design-msgs
sno-bot--bolt
sno-fix-test-2025-10-29
sno-better-auth
sno-dedup-desktop-release-notification
feat/comfypr-bot-skills
fix/coreping-hours-from-last-activity
copilot/sub-pr-105-yet-again
copilot/sub-pr-105-another-one
sno-solve-comfy-pr-job
sno-method-cache-proxy
sno-fix-pr-hourly-ci
sno-fix-cicd-2025-10-21
fix/template-file-path-bug
sno-update-vscode-settings
sno-debug-repo-urls-endpoint
sno-pr-speed
fix-duplicate-draft-announcements
stable-tag-announce
sno-slack-dry
sno-adjust-easy-label-timeout
sno-slack-cache
sno-slack-dm
sno-pr-button
test/pyproject-generation-validation
feat/winston-logger
easylabel-debug
sno-logger
feat/frontend-release-notes-in-slack
sno-frontend-release-notification
sno-coreping
sno-setupbunv2
replace-keyv-with-bun-sqlite
sno-update-readme
push-merged-changes
sno-rename-parseUrlRepoOwner
61-test-evidence
sno-easylabel-allowlist
sno-bugcop-label
sno-fix-bugcop
sno-label-op-system
sno-notification-reply-boardcast
sno-slack-release-msg
sno-bugcop-dont-set-answered
snomiao-patch-token-bot
sno-bugcop-update-existed-task
sno-bugcop-responsed
sno-setup-lint-stage
sno-desktop-release-notification
sno-bugcop-logic-update
sno-disable-meta-editing
sno-bug-cop
sno-patch-zodv3
revert-33-copilot/fix-32
copilot/fix-32
gh-readonly-queue/main/pr-31-8a0f19f72fa4a0ee197d7ce2131d5dcd4b6bd7d0
sno-zodv3
sno-design-label-track
fix-contribute-analyze-ci
sno-db-refactor
sno-bounty
sno-pkg-update
sno-filter-unclaimed
sno-clone-single-branch
prevent-duplicate-pr
mass-pr
action-permission-write
fix-deployment-2025-01-12
fix-repository-owner
rh-update
test-robin-pr
update-readme
sno-checking-prs-failures
update-toml-pr
sno-license-updator
gmail
update-dashboard-summary
update-pr-status
storybook
toml-v4
stale-counter
toml-template-v3
sno-sep-apidoc
actions-pr-v2
publish-yaml-outdated
edit-toml-PR-message
edit-pyproject-PR-message
feat-activate-in-bun
pyproject--snomiao--ComfyNode-Registry-test
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.1
v1.0.0
v0.2.27
v0.0.2
v0.0.1
Labels
Clear labels   
bug-cop:response-received

   
Core

   
Core-Important

   
pull-request
Mirrored from GitHub Pull Request

  
stale

   
Test

   
world
No labels
bug-cop:response-received
Core
Core-Important
pull-request
stale
Test
world
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/Comfy-PR#172
No description provided.