[PR #173] [MERGED] fix(lint): resolve oxlint warnings and errors #173

New issue

Closed

opened 2026-10-27 21:10:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/173
Author: @comfy-pr-bot
Created: 2/20/2026
Status: ✅ Merged
Merged: 2/20/2026
Merged by: @comfy-pr-bot

Base: main ← Head: sno-fmt

📝 Commits (5)

2e1c9db fix(lint): remove unused imports
a8fc679 fix(lint): prefix unused variables and parameters with underscore
13b5ef2 fix(lint): convert side-effect expressions to if statements
663113c fix(lint): misc lint fixes
beac2b7 chore: code formatting and cleanup

📊 Changes

88 files changed (+423 additions, -320 deletions)

View changed files

📝 .bot/AGENT.md (+5 -0)
📝 app/(dashboard)/followup/actions/send-gmail/page.tsx (+1 -1)
📝 app/api/router.ts (+1 -1)
📝 app/api/webhook/github/route.ts (+1 -1)
📝 app/tasks/coreping/coreping.ts (+2 -2)
📝 app/tasks/gh-bounty/gh-bounty.ts (+16 -12)
📝 app/tasks/gh-core-tag-notification/index.ts (+7 -5)
📝 app/tasks/gh-design/gh-design.ts (+1 -1)
📝 app/tasks/gh-design/page.tsx (+1 -1)
📝 app/tasks/gh-desktop-release-notification/index.ts (+7 -5)
📝 app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts (+4 -4)
📝 app/tasks/gh-frontend-backport-checker/index.ts (+3 -9)
📝 app/tasks/gh-frontend-release-notification/index.ts (+7 -5)
📝 app/tasks/gh-issue-transfer-comfyui-to-desktop/index.ts (+10 -6)
📝 app/tasks/gh-issue-transfer-comfyui-to-frontend/index.ts (+10 -6)
📝 app/tasks/gh-issue-transfer-comfyui-to-workflow_templates/index.ts (+10 -6)
📝 app/tasks/gh-issue-transfer-desktop-to-frontend/index.ts (+10 -6)
📝 app/tasks/gh-issue-transfer-frontend-to-comfyui/index.ts (+10 -6)
📝 app/tasks/gh-issue-transfer-frontend-to-desktop/index.ts (+10 -6)
📝 app/tasks/gh-priority-sync/index.spec.ts (+2 -2)

...and 68 more files

📄 Description

Summary

Remove unused imports across bot, lib, and app directories
Prefix unused variables and parameters with underscore to satisfy linter
Convert side-effect expressions (&&/||) to proper if statements
Fix misc lint issues: top-level await, empty files, erasing operations

Changes by commit

fix(lint): remove unused imports - Clean up ~20 unused imports
fix(lint): prefix unused variables - Add _ prefix to ~50 unused vars/params
fix(lint): convert side-effect expressions - Fix ~15 no-unused-expressions warnings
fix(lint): misc lint fixes - Fix top-level await, empty pattern, erasing op
chore: code formatting - Apply consistent formatting

Lint results

Before: 218 warnings and 1 error
After: 62 warnings and 0 errors

Remaining warnings are acceptable/intentional (control chars in regex, self-assign for page refresh, etc.)

Test plan

bun lint passes with 0 errors
CI build passes

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/173 **Author:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Created:** 2/20/2026 **Status:** ✅ Merged **Merged:** 2/20/2026 **Merged by:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Base:** `main` ← **Head:** `sno-fmt` --- ### 📝 Commits (5) - [`2e1c9db`](https://github.com/Comfy-Org/Comfy-PR/commit/2e1c9dbde5d391648d54de3befbf28135c7c7a23) fix(lint): remove unused imports - [`a8fc679`](https://github.com/Comfy-Org/Comfy-PR/commit/a8fc679a6face9c1f93a534efd0af3988159864b) fix(lint): prefix unused variables and parameters with underscore - [`13b5ef2`](https://github.com/Comfy-Org/Comfy-PR/commit/13b5ef26b59d8000d9b78cf11b74f1e5e84cfb69) fix(lint): convert side-effect expressions to if statements - [`663113c`](https://github.com/Comfy-Org/Comfy-PR/commit/663113c295f38083a713d89aa1e56654780af4b3) fix(lint): misc lint fixes - [`beac2b7`](https://github.com/Comfy-Org/Comfy-PR/commit/beac2b7e2c4ebb88f63cf953595d8d54762f7473) chore: code formatting and cleanup ### 📊 Changes **88 files changed** (+423 additions, -320 deletions) <details> <summary>View changed files</summary> 📝 `.bot/AGENT.md` (+5 -0) 📝 `app/(dashboard)/followup/actions/send-gmail/page.tsx` (+1 -1) 📝 `app/api/router.ts` (+1 -1) 📝 `app/api/webhook/github/route.ts` (+1 -1) 📝 `app/tasks/coreping/coreping.ts` (+2 -2) 📝 `app/tasks/gh-bounty/gh-bounty.ts` (+16 -12) 📝 `app/tasks/gh-core-tag-notification/index.ts` (+7 -5) 📝 `app/tasks/gh-design/gh-design.ts` (+1 -1) 📝 `app/tasks/gh-design/page.tsx` (+1 -1) 📝 `app/tasks/gh-desktop-release-notification/index.ts` (+7 -5) 📝 `app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts` (+4 -4) 📝 `app/tasks/gh-frontend-backport-checker/index.ts` (+3 -9) 📝 `app/tasks/gh-frontend-release-notification/index.ts` (+7 -5) 📝 `app/tasks/gh-issue-transfer-comfyui-to-desktop/index.ts` (+10 -6) 📝 `app/tasks/gh-issue-transfer-comfyui-to-frontend/index.ts` (+10 -6) 📝 `app/tasks/gh-issue-transfer-comfyui-to-workflow_templates/index.ts` (+10 -6) 📝 `app/tasks/gh-issue-transfer-desktop-to-frontend/index.ts` (+10 -6) 📝 `app/tasks/gh-issue-transfer-frontend-to-comfyui/index.ts` (+10 -6) 📝 `app/tasks/gh-issue-transfer-frontend-to-desktop/index.ts` (+10 -6) 📝 `app/tasks/gh-priority-sync/index.spec.ts` (+2 -2) _...and 68 more files_ </details> ### 📄 Description ## Summary - Remove unused imports across bot, lib, and app directories - Prefix unused variables and parameters with underscore to satisfy linter - Convert side-effect expressions (`&&`/`||`) to proper `if` statements - Fix misc lint issues: top-level await, empty files, erasing operations ## Changes by commit 1. **fix(lint): remove unused imports** - Clean up ~20 unused imports 2. **fix(lint): prefix unused variables** - Add `_` prefix to ~50 unused vars/params 3. **fix(lint): convert side-effect expressions** - Fix ~15 `no-unused-expressions` warnings 4. **fix(lint): misc lint fixes** - Fix top-level await, empty pattern, erasing op 5. **chore: code formatting** - Apply consistent formatting ## Lint results - **Before**: 218 warnings and 1 error - **After**: 62 warnings and 0 errors Remaining warnings are acceptable/intentional (control chars in regex, self-assign for page refresh, etc.) ## Test plan - [x] `bun lint` passes with 0 errors - [ ] CI build passes 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:10:15 +00:00