[PR #200] fix: skip backport checks for releases not from main branch #200

New issue

Open

opened 2026-10-27 21:10:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:10:33 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/200
Author: @comfy-pr-bot
Created: 4/13/2026
Status: 🔄 Open

Base: main ← Head: fix/backport-checker-skip-non-main-releases

📝 Commits (1)

1661907 fix: skip backport checks for releases not from main branch

📊 Changes

1 file changed (+16 additions, -0 deletions)

View changed files

📝 app/tasks/gh-frontend-backport-checker/index.ts (+16 -0)

📄 Description

Problem

The backport checker was running for ALL releases from ComfyUI_frontend, including patch releases made from RC branches like core/1.42. Christian Byrne pointed out that we do NOT need to check backports when a release is NOT made from the main branch — releases from RC branches already have their commits on that branch, so there's nothing to backport.

Changes

Added mainBranch: 'main' config option so the filter is configurable
Added a filter in the sflow pipeline to skip releases where target_commitish !== config.mainBranch
Added a logger.debug message when skipping non-main releases (shows the tag name and actual target branch)
Updated the JSDoc comment (step 2 in HOW IT WORKS) to document this new filtering step

How it works

GitHub releases have a target_commitish field indicating the branch/commit the release was created from:

Main branch releases: target_commitish === 'main'
RC branch releases (e.g. v1.42.9): target_commitish === 'core/1.42'

The new filter skips any release where target_commitish doesn't match config.mainBranch.

Testing

Run with --dry-run against the frontend repo and verify that releases like v1.42.9 (from core/1.42) are skipped with a debug log, while main branch releases continue to be processed normally.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/200 **Author:** [@comfy-pr-bot](https://github.com/comfy-pr-bot) **Created:** 4/13/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/backport-checker-skip-non-main-releases` --- ### 📝 Commits (1) - [`1661907`](https://github.com/Comfy-Org/Comfy-PR/commit/16619072580b77d2cd7799f0404ae7abba711f69) fix: skip backport checks for releases not from main branch ### 📊 Changes **1 file changed** (+16 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/tasks/gh-frontend-backport-checker/index.ts` (+16 -0) </details> ### 📄 Description ## Problem The backport checker was running for ALL releases from ComfyUI_frontend, including patch releases made from RC branches like `core/1.42`. Christian Byrne pointed out that we do NOT need to check backports when a release is NOT made from the main branch — releases from RC branches already have their commits on that branch, so there's nothing to backport. ## Changes - Added `mainBranch: 'main'` config option so the filter is configurable - Added a filter in the `sflow` pipeline to skip releases where `target_commitish !== config.mainBranch` - Added a `logger.debug` message when skipping non-main releases (shows the tag name and actual target branch) - Updated the JSDoc comment (step 2 in HOW IT WORKS) to document this new filtering step ## How it works GitHub releases have a `target_commitish` field indicating the branch/commit the release was created from: - Main branch releases: `target_commitish === 'main'` - RC branch releases (e.g. v1.42.9): `target_commitish === 'core/1.42'` The new filter skips any release where `target_commitish` doesn't match `config.mainBranch`. ## Testing Run with `--dry-run` against the frontend repo and verify that releases like `v1.42.9` (from `core/1.42`) are skipped with a debug log, while main branch releases continue to be processed normally. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:10:33 +00:00