Comfy-Org/Comfy-PR
1
0
Fork 0
mirror of https://github.com/Comfy-Org/Comfy-PR.git synced 2026-11-04 23:37:33 +00:00
Code Issues 18 Projects Packages Wiki Activity

[PR #58] [MERGED] feat(easylabel): add allowAdd and allowRemove patterns for controlled label operations #59

New issue
Closed
opened 2026-10-27 21:09:11 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-27 21:09:11 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/58
Author: @snomiao
Created: 8/19/2025
Status: ✅ Merged
Merged: 8/19/2025
Merged by: @snomiao

Base: main ← Head: sno-easylabel-allowlist

📝 Commits (4)

  • 855127a feat(easylabel.tsx): add allowAdd and allowRemove patterns to control label operations for better validation
  • 937e518 feat(easylabel): add allowAdd and allowRemove patterns for controlled label operations
  • 6ca2b47 fix(easylabel.tsx): remove unnecessary label pattern from allow array to simplify configuration and improve clarity
  • 56c629f fix(easylabel.tsx): await createIndex to ensure proper execution of index creation before proceeding with other operations

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 run/easylabel.tsx (+6 -2)

📄 Description

Summary

  • Add allowAdd and allowRemove patterns to control label operations for better validation
  • Implement checks to skip disallowed labels during addition and removal operations
  • Await createIndex to ensure proper execution of index creation before proceeding with other operations
  • Remove unnecessary label pattern from allow array to simplify configuration and improve clarity

Test plan

  • Verify allowAdd patterns work correctly
  • Verify allowRemove patterns work correctly
  • Test that disallowed labels are skipped during operations
  • Confirm index creation awaits properly

🤖 Generated with Claude Code

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/58 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 8/19/2025 **Status:** ✅ Merged **Merged:** 8/19/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `sno-easylabel-allowlist` --- ### 📝 Commits (4) - [`855127a`](https://github.com/Comfy-Org/Comfy-PR/commit/855127a62b317c8d7d94fb8eacd23500d6dcb675) feat(easylabel.tsx): add allowAdd and allowRemove patterns to control label operations for better validation - [`937e518`](https://github.com/Comfy-Org/Comfy-PR/commit/937e518400ff4cde96d376726247cfb4a7033a55) feat(easylabel): add allowAdd and allowRemove patterns for controlled label operations - [`6ca2b47`](https://github.com/Comfy-Org/Comfy-PR/commit/6ca2b47874e7c78d836cdc4f8824403efb400767) fix(easylabel.tsx): remove unnecessary label pattern from allow array to simplify configuration and improve clarity - [`56c629f`](https://github.com/Comfy-Org/Comfy-PR/commit/56c629f9e7a4cb1686e81866794cc8c7a09ca3d2) fix(easylabel.tsx): await createIndex to ensure proper execution of index creation before proceeding with other operations ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `run/easylabel.tsx` (+6 -2) </details> ### 📄 Description ## Summary - Add allowAdd and allowRemove patterns to control label operations for better validation - Implement checks to skip disallowed labels during addition and removal operations - Await createIndex to ensure proper execution of index creation before proceeding with other operations - Remove unnecessary label pattern from allow array to simplify configuration and improve clarity ## Test plan - [x] Verify allowAdd patterns work correctly - [x] Verify allowRemove patterns work correctly - [x] Test that disallowed labels are skipped during operations - [x] Confirm index creation awaits properly 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/release-tagger-branch-cut
matt/be-3554-claude-md-shim
cb__backport-checker-released-status
fix/gh-combined-tasks-concurrency-guard
sno-coreping-groupby-author
sno-bot
sno/fix-notion-cursor-priority-sync
fix/gh-design-self-review
fix/backport-checker-skip-non-main-releases
refactor/merge-bot-cli-into-index
fix/flaky-workflow-templates-test
sno-release
sno-qabot
sno-fix-test-2025-11-05
sno-fix-msg-post-2026-02-18
copilot/sub-pr-179-another-one
copilot/sub-pr-179-again
copilot/sub-pr-179
sno-perf-2026-03-01
sno-test-evidence
sno-fix-repolist-endpoint
sno-priorities-backsync
fix/housekeeping
sno-cloudrun
pr/oxlint-type-safety
feature/backport-label-emoji
sno-design-msgs
sno-bot--bolt
sno-fix-test-2025-10-29
sno-better-auth
sno-dedup-desktop-release-notification
feat/comfypr-bot-skills
fix/coreping-hours-from-last-activity
copilot/sub-pr-105-yet-again
copilot/sub-pr-105-another-one
sno-solve-comfy-pr-job
sno-method-cache-proxy
sno-fix-pr-hourly-ci
sno-fix-cicd-2025-10-21
fix/template-file-path-bug
sno-update-vscode-settings
sno-debug-repo-urls-endpoint
sno-pr-speed
fix-duplicate-draft-announcements
stable-tag-announce
sno-slack-dry
sno-adjust-easy-label-timeout
sno-slack-cache
sno-slack-dm
sno-pr-button
test/pyproject-generation-validation
feat/winston-logger
easylabel-debug
sno-logger
feat/frontend-release-notes-in-slack
sno-frontend-release-notification
sno-coreping
sno-setupbunv2
replace-keyv-with-bun-sqlite
sno-update-readme
push-merged-changes
sno-rename-parseUrlRepoOwner
61-test-evidence
sno-easylabel-allowlist
sno-bugcop-label
sno-fix-bugcop
sno-label-op-system
sno-notification-reply-boardcast
sno-slack-release-msg
sno-bugcop-dont-set-answered
snomiao-patch-token-bot
sno-bugcop-update-existed-task
sno-bugcop-responsed
sno-setup-lint-stage
sno-desktop-release-notification
sno-bugcop-logic-update
sno-disable-meta-editing
sno-bug-cop
sno-patch-zodv3
revert-33-copilot/fix-32
copilot/fix-32
gh-readonly-queue/main/pr-31-8a0f19f72fa4a0ee197d7ce2131d5dcd4b6bd7d0
sno-zodv3
sno-design-label-track
fix-contribute-analyze-ci
sno-db-refactor
sno-bounty
sno-pkg-update
sno-filter-unclaimed
sno-clone-single-branch
prevent-duplicate-pr
mass-pr
action-permission-write
fix-deployment-2025-01-12
fix-repository-owner
rh-update
test-robin-pr
update-readme
sno-checking-prs-failures
update-toml-pr
sno-license-updator
gmail
update-dashboard-summary
update-pr-status
storybook
toml-v4
stale-counter
toml-template-v3
sno-sep-apidoc
actions-pr-v2
publish-yaml-outdated
edit-toml-PR-message
edit-pyproject-PR-message
feat-activate-in-bun
pyproject--snomiao--ComfyNode-Registry-test
v1.6.1
v1.6.0
v1.5.1
v1.5.0
v1.4.2
v1.4.1
v1.4.0
v1.3.0
v1.2.2
v1.2.1
v1.2.0
v1.1.0
v1.0.1
v1.0.0
v0.2.27
v0.0.2
v0.0.1
Labels
Clear labels   
bug-cop:response-received

   
Core

   
Core-Important

   
pull-request
Mirrored from GitHub Pull Request

  
stale

   
Test

   
world
No labels
bug-cop:response-received
Core
Core-Important
pull-request
stale
Test
world
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/Comfy-PR#59
No description provided.