[PR #59] [MERGED] feat(coreping): filter out draft PRs from Core/Important PR notifications #60

New issue

Closed

opened 2026-10-27 21:09:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:09:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/59
Author: @snomiao
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @snomiao

Base: main ← Head: sno-coreping

📝 Commits (1)

36157ad feat(coreping): filter out draft PRs from Core/Important PR notifications

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 app/tasks/coreping/index.tsx (+1 -0)

📄 Description

Summary

Filter out draft PRs from Core/Important PR notification messages
Draft PRs are now marked as "unrelated" status and excluded from Slack reminders

Problem

CorePing was including draft PRs in the Core/Important PR reminder messages sent to @comfyanonymous, but draft PRs are not ready for review yet and shouldn't be included in these notifications.

Solution

Added a check for pr.draft after the existing checks for core labels and closed status. Draft PRs are now marked with status "unrelated" and a descriptive status message "Draft PR, skipping".

Test plan

Verify the draft check is added in the correct location in the filtering logic
Confirm draft PRs will be excluded from both stale and fresh Core/Important PR collections
Ensure the change maintains existing functionality for non-draft PRs

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/59 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `sno-coreping` --- ### 📝 Commits (1) - [`36157ad`](https://github.com/Comfy-Org/Comfy-PR/commit/36157adeade916a01c17093eaf6cc61fc3aaba9a) feat(coreping): filter out draft PRs from Core/Important PR notifications ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `app/tasks/coreping/index.tsx` (+1 -0) </details> ### 📄 Description ## Summary - Filter out draft PRs from Core/Important PR notification messages - Draft PRs are now marked as "unrelated" status and excluded from Slack reminders ## Problem CorePing was including draft PRs in the Core/Important PR reminder messages sent to @comfyanonymous, but draft PRs are not ready for review yet and shouldn't be included in these notifications. ## Solution Added a check for `pr.draft` after the existing checks for core labels and closed status. Draft PRs are now marked with status "unrelated" and a descriptive status message "Draft PR, skipping". ## Test plan - [x] Verify the draft check is added in the correct location in the filtering logic - [x] Confirm draft PRs will be excluded from both stale and fresh Core/Important PR collections - [x] Ensure the change maintains existing functionality for non-draft PRs 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi added the

pull-request

label

2026-10-27 21:09:11 +00:00

bsakaguchi referenced this issue

2026-10-27 21:09:12 +00:00

[PR #60] [MERGED] refactor(coreping): migrate from index.tsx to coreping.ts implementation #61

bsakaguchi closed this issue

2026-10-27 21:09:12 +00:00