[PR #60] [MERGED] refactor(coreping): migrate from index.tsx to coreping.ts implementation #61

New issue

Closed

opened 2026-10-27 21:09:12 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-27 21:09:12 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/Comfy-PR/pull/60
Author: @snomiao
Created: 8/22/2025
Status: ✅ Merged
Merged: 8/22/2025
Merged by: @snomiao

Base: main ← Head: sno-coreping

📝 Commits (4)

36157ad feat(coreping): filter out draft PRs from Core/Important PR notifications
7643586 refactor(coreping): migrate from index.tsx to coreping.ts implementation
8409243 resolve merge conflict: keep draft PR filtering from main
cdc0a25 fix(workflow): update CorePing task script path from index.tsx to coreping.ts to ensure correct execution

📊 Changes

3 files changed (+7 additions, -4 deletions)

View changed files

📝 .github/workflows/coreping.yaml (+1 -1)
📝 app/tasks/coreping/coreping.ts (+4 -1)
📝 app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts (+2 -2)

📄 Description

Summary

Replace React-based index.tsx with TypeScript coreping.ts
Update file structure for better maintainability
Consolidate coreping functionality into single TypeScript module

Test plan

Verify coreping functionality works as expected
Check that all imports and dependencies are correct
Ensure no breaking changes to existing workflows

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/Comfy-PR/pull/60 **Author:** [@snomiao](https://github.com/snomiao) **Created:** 8/22/2025 **Status:** ✅ Merged **Merged:** 8/22/2025 **Merged by:** [@snomiao](https://github.com/snomiao) **Base:** `main` ← **Head:** `sno-coreping` --- ### 📝 Commits (4) - [`36157ad`](https://github.com/Comfy-Org/Comfy-PR/commit/36157adeade916a01c17093eaf6cc61fc3aaba9a) feat(coreping): filter out draft PRs from Core/Important PR notifications - [`7643586`](https://github.com/Comfy-Org/Comfy-PR/commit/764358643255bd6b9f6abfd5dff171f7d652643a) refactor(coreping): migrate from index.tsx to coreping.ts implementation - [`8409243`](https://github.com/Comfy-Org/Comfy-PR/commit/840924330273f6587dff6a29ad591f40b223dd55) resolve merge conflict: keep draft PR filtering from main - [`cdc0a25`](https://github.com/Comfy-Org/Comfy-PR/commit/cdc0a25df784e569a50ad0a1a1ae9605770be0ba) fix(workflow): update CorePing task script path from index.tsx to coreping.ts to ensure correct execution ### 📊 Changes **3 files changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/coreping.yaml` (+1 -1) 📝 `app/tasks/coreping/coreping.ts` (+4 -1) 📝 `app/tasks/gh-desktop-release-notification/upsertSlackMessage.ts` (+2 -2) </details> ### 📄 Description ## Summary - Replace React-based index.tsx with TypeScript coreping.ts - Update file structure for better maintainability - Consolidate coreping functionality into single TypeScript module ## Test plan - [ ] Verify coreping functionality works as expected - [ ] Check that all imports and dependencies are correct - [ ] Ensure no breaking changes to existing workflows 🤖 Generated with [Claude Code](https://claude.ai/code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-27 21:09:12 +00:00