Comfy-Org/ComfyUI-Manager
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI-Manager.git synced 2026-11-05 07:47:25 +00:00
Code Issues 456 Projects Packages Wiki Activity

[PR #1432] [MERGED] Fix node version metadata #1897

New issue
Closed
opened 2026-10-28 21:05:16 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-28 21:05:16 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Manager/pull/1432
Author: @huchenlei
Created: 1/10/2025
Status: ✅ Merged
Merged: 1/10/2025
Merged by: @huchenlei

Base: main ← Head: fix_metadata2

📝 Commits (1)

  • 18d043d Fix node version metadata

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 js/workflow-metadata.js (+8 -2)

📄 Description

Resolves https://github.com/ltdrdata/ComfyUI-Manager/issues/1422
Resolves https://github.com/ltdrdata/ComfyUI-Manager/issues/1428

This PR explicitly handles undefined node info, and prevents any error of the metadata logic to break all serialization.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Manager/pull/1432 **Author:** [@huchenlei](https://github.com/huchenlei) **Created:** 1/10/2025 **Status:** ✅ Merged **Merged:** 1/10/2025 **Merged by:** [@huchenlei](https://github.com/huchenlei) **Base:** `main` ← **Head:** `fix_metadata2` --- ### 📝 Commits (1) - [`18d043d`](https://github.com/Comfy-Org/ComfyUI-Manager/commit/18d043d5b0981f80a74c365c39cbb294de7797cc) Fix node version metadata ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `js/workflow-metadata.js` (+8 -2) </details> ### 📄 Description Resolves https://github.com/ltdrdata/ComfyUI-Manager/issues/1422 Resolves https://github.com/ltdrdata/ComfyUI-Manager/issues/1428 This PR explicitly handles undefined node info, and prevents any error of the metadata logic to break all serialization. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-28 21:05:16 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/per-graph-clear-hook
fix/manager-theme-styles
desktop-linux-form-factor
chore/node-runtime-refresh-2026-09-28
manager-v4
feat/v4-flagged-policy
fix/v3-ui-escaping
fix/v4-ui-escaping
feat/v3-flagged-policy
fix/v4-uv-conflict-attribution
test/issue-3128-c1-guard
fix/issue-3128-c1
feat/v4-dedicated-install-flags
fix/pygit2-fallback-followups
fix/comfyui-versions-pick-latest
brucew4yn3rp/main
manager-cacheless
feat/manager-v4-general-pip-policy
readme-for-migration
draft-v4
reverted-matrix-nio
fix/missing-nodes-in-subgraph
draft-v4-snapshot-diff
feat/add-taskqueue-unit-tests
feat/complete-todo-implementation
docs/docs-readme
docs/js-readme
tests/api-tests
api/openapi-spec
docs/node-db-readme
docs/glob-readme
draft-v4-add-legacy-route
draft-v4-contributing
feat/cacheless-v2
rh-test
rhform
dbg1484-1
rework_version_store
attach_node_versions
refactor/pygit2
4.3
3.42
4.2.2
4.2.1
4.1
3.39.3
4.1b8
4.1b6
4.1b5
4.1b4
4.1b3
4.1b2
4.1b1
4.0.5
3.39.2
3.39.1
4.0.4
4.0.3
3.39
3.38.3
3.38.2
3.38
3.37.1
3.37
3.35
3.33.8
3.33.7
3.33.6
3.33.5
3.33.4
3.33.3
3.33.2
3.33
3.32.5
3.32.4
3.32.3
3.32.2
3.32.1
3.32
3.31.13
3.31.12
3.31.11
3.31.8
3.31.6
3.31.4
3.31.2
3.31.1
3.31
3.30.8
3.30.7
3.30.6
3.30.5
3.30.4
3.30.2
3.29
3.28
3.27.11
3.27.8
3.27.3
3.27.2
3.27
3.26.2
3.26.1
3.26
3.25.1
3.25
3.24.1
3.24
3.23
3.22
3.21.5
3.21.3
3.21.1
3.19
3.18.1
3.17.11
3.17.9
3.17.7
3.17.6
3.17.4
3.17.3
3.17.2
3.17.1
3.17
3.16
3.15
3.14
3.13.1
3.13
3.12.2
3.12.1
3.12
3.11.3
3.11.2
3.11
3.10
3.9.4
3.9.3
3.9.2
3.9.1
3.9
3.8.1
3.8
3.7.6
3.7.5
3.7.4
3.7.3
3.7.2
3.7
3.6.5
3.6.4
3.6.2
3.6.1
3.5
3.3.11
3.3.10
3.3.9
3.3.8
3.3.7
3.3.6
3.3.5
3.3.4
3.3.3
3.3.2
2.56.2
3.3
2.55.5
2.55.3
2.54
2.53
2.52
3.0.1
2.51.9
2.51.8
2.51.7
2.51.6
2.51.5
2.51.4
2.51.2
2.51.1
2.50.1
2.50
2.48.7
2.48.6
2.48.3
2.48.4
2.48.2
2.48.1
Labels
Clear labels   
bug

   
CNR

   
duplicate

   
enhancement

   
feature request

   
feature request

   
pull-request
Mirrored from GitHub Pull Request

  
wontfix
No labels
bug
CNR
duplicate
enhancement
feature request
feature request
pull-request
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#1897
No description provided.