[GH-ISSUE #598] __win_check_git_update prints stdout, but not stderr on failure #274

Open
opened 2026-10-27 21:15:36 +00:00 by bsakaguchi · 3 comments
Owner

Originally created by @DrJKL on GitHub (Apr 22, 2024).
Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/598

Having an issue with git_helper.py disappearing and updates failing, the logs weren't very helpful.
Tracked it down to ~285 in manager_core.py where the stderr becomes _ and isn't printed in the "Fetch error: block below.

Originally created by @DrJKL on GitHub (Apr 22, 2024). Original GitHub issue: https://github.com/Comfy-Org/ComfyUI-Manager/issues/598 Having an issue with `git_helper.py` disappearing and updates failing, the logs weren't very helpful. Tracked it down to ~285 in `manager_core.py` where the stderr becomes `_` and isn't printed in the `"Fetch error:` block below.
Author
Owner

@ltdrdata commented on GitHub (Apr 23, 2024):

I'm not exactly sure what situation you are describing.
Also, the line you indicated differs from the current line. Please update to the latest version and explain based on that.

<!-- gh-comment-id:2071288831 --> @ltdrdata commented on GitHub (Apr 23, 2024): I'm not exactly sure what situation you are describing. Also, the line you indicated differs from the current line. Please update to the latest version and explain based on that.
Author
Owner

@DrJKL commented on GitHub (Apr 23, 2024):

Okay, made a minimal PR to demo:
https://github.com/ltdrdata/ComfyUI-Manager/pull/603

<!-- gh-comment-id:2073091898 --> @DrJKL commented on GitHub (Apr 23, 2024): Okay, made a minimal PR to demo: https://github.com/ltdrdata/ComfyUI-Manager/pull/603
Author
Owner

@DrJKL commented on GitHub (Apr 23, 2024):

Probably should have gone with that in the first place :-D

<!-- gh-comment-id:2073092276 --> @DrJKL commented on GitHub (Apr 23, 2024): Probably should have gone with that in the first place :-D
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Comfy-Org/ComfyUI-Manager#274
No description provided.