[PR #16] [MERGED] Remove obsolete per-arch AMD requirements; merge latest.json on partial builds #17

New issue

Closed

opened 2026-10-26 22:22:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:22:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/16
Author: @Kosinkadink
Created: 7/28/2026
Status: ✅ Merged
Merged: 7/28/2026
Merged by: @Kosinkadink

Base: main ← Head: chore/remove-obsolete-amd-rdna-requirements

📝 Commits (2)

1ee1769 Remove obsolete per-arch AMD requirements; merge latest.json on partial builds
890cb5d Bump AMD variants to validated 2.11.0+rocm7.14.0 tuple

📊 Changes

6 files changed (+15 additions, -35 deletions)

View changed files

📝 .github/workflows/build-standalone-env.yml (+9 -2)
➖ requirements-amd-rdna3.txt (+0 -9)
➖ requirements-amd-rdna35.txt (+0 -9)
➖ requirements-amd-rdna4.txt (+0 -9)
📝 requirements-amd-win.txt (+3 -3)
📝 requirements-amd.txt (+3 -3)

📄 Description

What

Removes requirements-amd-rdna3.txt, requirements-amd-rdna35.txt, and requirements-amd-rdna4.txt. The AMD variants now use the ROCm multi-arch index, so only requirements-amd.txt (linux-amd) and requirements-amd-win.txt (win-amd) are needed. Nothing else in the repo references the removed files (build matrix and scripts/build_local.py already point at the two surviving files).
Bumps both AMD variants from 2.10.0+rocm7.14.0 to the GPU-validated tuple: torch 2.11.0+rocm7.14.0 / torchvision 0.26.0+rocm7.14.0 / torchaudio 2.11.0+rocm7.14.0. This exact tuple completed real SD 1.5 inference on Linux (RX 7600 / gfx1102) and Windows (Radeon PRO W7800 / gfx1100); the previous 2.10.0 multi-arch pin was never directly validated.
Fixes a partial-build hazard in the publish step of build-standalone-env.yml: latest.json was rebuilt only from the vendors built in the current run, so a partial-matrix run (e.g. rebuilding only the AMD variants by commenting out other matrix entries) would silently drop every other vendor from the catalog that ComfyUI Desktop consumes. The step now downloads the existing latest.json and merges this run's vendors into it, matching how per-vendor releases.json files are already merged.

Why

Preparing selective AMD Windows + Linux rebuilds on the multi-arch ROCm stacks; the latest.json merge makes that partial release safe for all other platforms.

Follow-up

Validate torch 2.11.0 on the other backends (CUDA, MPS, XPU) and bump those variants in a later PR.

Validation

python -m unittest scripts.test_local_tooling: 20 tests OK
python -m unittest scripts.test_torch_index_scripts: OK
python scripts/validate_torch_index_stacks.py torch-index-stacks.json: valid (34 stacks)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/16 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 7/28/2026 **Status:** ✅ Merged **Merged:** 7/28/2026 **Merged by:** [@Kosinkadink](https://github.com/Kosinkadink) **Base:** `main` ← **Head:** `chore/remove-obsolete-amd-rdna-requirements` --- ### 📝 Commits (2) - [`1ee1769`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/1ee1769dbb071f5c0a85f92f7d587058527ed585) Remove obsolete per-arch AMD requirements; merge latest.json on partial builds - [`890cb5d`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/890cb5d2a93ed9cabc4b8d3079fccecb6f1b791f) Bump AMD variants to validated 2.11.0+rocm7.14.0 tuple ### 📊 Changes **6 files changed** (+15 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-standalone-env.yml` (+9 -2) ➖ `requirements-amd-rdna3.txt` (+0 -9) ➖ `requirements-amd-rdna35.txt` (+0 -9) ➖ `requirements-amd-rdna4.txt` (+0 -9) 📝 `requirements-amd-win.txt` (+3 -3) 📝 `requirements-amd.txt` (+3 -3) </details> ### 📄 Description ## What - Removes `requirements-amd-rdna3.txt`, `requirements-amd-rdna35.txt`, and `requirements-amd-rdna4.txt`. The AMD variants now use the ROCm multi-arch index, so only `requirements-amd.txt` (linux-amd) and `requirements-amd-win.txt` (win-amd) are needed. Nothing else in the repo references the removed files (build matrix and `scripts/build_local.py` already point at the two surviving files). - Bumps both AMD variants from `2.10.0+rocm7.14.0` to the GPU-validated tuple: torch `2.11.0+rocm7.14.0` / torchvision `0.26.0+rocm7.14.0` / torchaudio `2.11.0+rocm7.14.0`. This exact tuple completed real SD 1.5 inference on Linux (RX 7600 / gfx1102) and Windows (Radeon PRO W7800 / gfx1100); the previous 2.10.0 multi-arch pin was never directly validated. - Fixes a partial-build hazard in the publish step of `build-standalone-env.yml`: `latest.json` was rebuilt only from the vendors built in the current run, so a partial-matrix run (e.g. rebuilding only the AMD variants by commenting out other matrix entries) would silently drop every other vendor from the catalog that ComfyUI Desktop consumes. The step now downloads the existing `latest.json` and merges this run's vendors into it, matching how per-vendor `releases.json` files are already merged. ## Why Preparing selective AMD Windows + Linux rebuilds on the multi-arch ROCm stacks; the `latest.json` merge makes that partial release safe for all other platforms. ## Follow-up Validate torch 2.11.0 on the other backends (CUDA, MPS, XPU) and bump those variants in a later PR. ## Validation - `python -m unittest scripts.test_local_tooling`: 20 tests OK - `python -m unittest scripts.test_torch_index_scripts`: OK - `python scripts/validate_torch_index_stacks.py torch-index-stacks.json`: valid (34 stacks) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:22:59 +00:00