[PR #17] [MERGED] Skip ELF strip for linux-amd multi-arch ROCm wheels #18

New issue

Closed

opened 2026-10-26 22:22:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:22:59 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/17
Author: @Kosinkadink
Created: 7/28/2026
Status: ✅ Merged
Merged: 7/28/2026
Merged by: @Kosinkadink

Base: main ← Head: fix/skip-strip-linux-amd

📝 Commits (1)

a882a66 Skip ELF strip for linux-amd multi-arch ROCm wheels

📊 Changes

1 file changed (+6 additions, -2 deletions)

View changed files

📝 .github/workflows/build-standalone-env.yml (+6 -2)

📄 Description

The linux-amd build of run 30401640591 failed its smoke test with ImportError: libtorch_hip.so: ELF load command address/offset not page-aligned. The 'Strip unnecessary files' step's strip --strip-debug pass corrupts the ELF page alignment of AMD's TheRock multi-arch ROCm libraries (the old pytorch.org ROCm wheels tolerated it). Skip shared-library stripping for the linux-amd variant; win-amd is unaffected (Windows never strips).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/17 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 7/28/2026 **Status:** ✅ Merged **Merged:** 7/28/2026 **Merged by:** [@Kosinkadink](https://github.com/Kosinkadink) **Base:** `main` ← **Head:** `fix/skip-strip-linux-amd` --- ### 📝 Commits (1) - [`a882a66`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/a882a66680c370cacd37d3360b4f51d446f1b86a) Skip ELF strip for linux-amd multi-arch ROCm wheels ### 📊 Changes **1 file changed** (+6 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/build-standalone-env.yml` (+6 -2) </details> ### 📄 Description The linux-amd build of run 30401640591 failed its smoke test with `ImportError: libtorch_hip.so: ELF load command address/offset not page-aligned`. The 'Strip unnecessary files' step's `strip --strip-debug` pass corrupts the ELF page alignment of AMD's TheRock multi-arch ROCm libraries (the old pytorch.org ROCm wheels tolerated it). Skip shared-library stripping for the linux-amd variant; win-amd is unaffected (Windows never strips). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:22:59 +00:00