[PR #1] [MERGED] fix: pin AMD Windows ROCm and torch versions to prevent CPU fallback #5

New issue

Closed

opened 2026-10-26 22:22:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-26 22:22:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/1
Author: @Kosinkadink
Created: 3/14/2026
Status: ✅ Merged
Merged: 3/14/2026
Merged by: @Kosinkadink

Base: main ← Head: fix/pin-amd-win-torch-versions

📝 Commits (1)

18d4a00 fix: pin AMD Windows ROCm and torch versions to prevent CPU fallback

📊 Changes

1 file changed (+8 additions, -7 deletions)

View changed files

📝 requirements-amd-win.txt (+8 -7)

📄 Description

Problem

The win-amd standalone build ships with torch 2.10.0+cpu instead of the ROCm-enabled torch. This happens because:

requirements-amd-win.txt uses --find-links to point to the ROCm repo, but lists bare torch/torchvision/torchaudio without version pins
--find-links merely adds the ROCm repo as an additional source — it doesn't restrict resolution to it
Since torch 2.10.0 (CPU-only, from PyPI) is newer than torch 2.9.1+rocmsdk20260116 (from ROCm repo), pip prefers the newer CPU wheel

This can be confirmed in the published manifests.json where win-amd shows torch_version: "2.10.0+cpu".

Fix

Pin all ROCm SDK and torch packages to the exact versions available on repo.radeon.com/rocm/windows/rocm-rel-7.2/. This is consistent with how the legacy desktop app (desktop/src/constants.ts) installs AMD packages via direct wheel URLs.

Verification

After this change, the CI build for win-amd should produce a manifest with torch_version: "2.9.1+rocmsdk20260116" instead of 2.10.0+cpu.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/pull/1 **Author:** [@Kosinkadink](https://github.com/Kosinkadink) **Created:** 3/14/2026 **Status:** ✅ Merged **Merged:** 3/14/2026 **Merged by:** [@Kosinkadink](https://github.com/Kosinkadink) **Base:** `main` ← **Head:** `fix/pin-amd-win-torch-versions` --- ### 📝 Commits (1) - [`18d4a00`](https://github.com/Comfy-Org/ComfyUI-Standalone-Environments/commit/18d4a00015c916268ce519def0bcc51d65470d5e) fix: pin AMD Windows ROCm and torch versions to prevent CPU fallback ### 📊 Changes **1 file changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `requirements-amd-win.txt` (+8 -7) </details> ### 📄 Description ## Problem The `win-amd` standalone build ships with `torch 2.10.0+cpu` instead of the ROCm-enabled torch. This happens because: 1. `requirements-amd-win.txt` uses `--find-links` to point to the ROCm repo, but lists bare `torch`/`torchvision`/`torchaudio` without version pins 2. `--find-links` merely *adds* the ROCm repo as an additional source — it doesn't restrict resolution to it 3. Since `torch 2.10.0` (CPU-only, from PyPI) is newer than `torch 2.9.1+rocmsdk20260116` (from ROCm repo), pip prefers the newer CPU wheel This can be confirmed in the published `manifests.json` where `win-amd` shows `torch_version: "2.10.0+cpu"`. ## Fix Pin all ROCm SDK and torch packages to the exact versions available on `repo.radeon.com/rocm/windows/rocm-rel-7.2/`. This is consistent with how the legacy desktop app (`desktop/src/constants.ts`) installs AMD packages via direct wheel URLs. ## Verification After this change, the CI build for `win-amd` should produce a manifest with `torch_version: "2.9.1+rocmsdk20260116"` instead of `2.10.0+cpu`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-26 22:22:52 +00:00