Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-06 16:10:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address PR review comments

Browse Source 
- Remove duplicate 'After Making Changes' section in browser_tests/AGENTS.md
- Remove unnecessary nextFrame() after loadWorkflow() in template
- Update gotchas table to clarify nextFrame() not needed after loadWorkflow()
- Update asset creation guidance for agents (manual JSON editing)
- Remove '(non-obvious)' from Vue Node CSS classes note
- Add local test command to CI debugging section

Amp-Thread-ID: https://ampcode.com/threads/T-019c265d-ca00-7024-8d9b-b1eb804e5390
This commit is contained in:
bymyself
2026-02-03 17:58:40 -08:00
parent 1393053abc
commit 0d36d2b854
2 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
.claude/skills/writing-playwright-tests/SKILL.md
View File

@@ -14,7 +14,7 @@ description: 'Writes Playwright e2e tests for ComfyUI_frontend. Use when creatin
3. **Use premade JSON workflow assets** instead of building workflows programmatically.
- Assets live in `browser_tests/assets/`
- Load with `await comfyPage.workflow.loadWorkflow('feature/my_workflow')`
- Create new assets by exporting from ComfyUI UI
- Create new assets by starting with `browser_tests/assets/default.json` and manually editing the JSON to match your desired graph state
## Vue Nodes vs LiteGraph: Decision Guide
@@ -32,7 +32,7 @@ await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
await comfyPage.vueNodes.waitForNodes()
```
**Vue Node state uses CSS classes** (non-obvious):
**Vue Node state uses CSS classes:**
```typescript
const BYPASS_CLASS = /before:bg-bypass\/60/
await expect(node).toHaveClass(BYPASS_CLASS)
@@ -42,7 +42,7 @@ await expect(node).toHaveClass(BYPASS_CLASS)
| Issue | Symptom | Fix |
| --------------------------- | ------------------------------------ | -------------------------------------------- |
| **Missing nextFrame()** | Test passes locally, fails in CI | Add `await comfyPage.nextFrame()` after canvas ops |
| **Missing nextFrame()** | Test passes locally, fails in CI | Add `await comfyPage.nextFrame()` after canvas ops (not needed after `loadWorkflow()`) |
| **Missing focus** | Keyboard shortcuts don't work | Add `await comfyPage.canvas.click()` first |
| **Double-click timing** | Double-click doesn't trigger | Add `{ delay: 5 }` option |
| **Drag animation** | Elements end up in wrong position | Use `{ steps: 10 }` not `{ steps: 1 }` |
@@ -107,6 +107,7 @@ await expect(async () => {
2. Extract and view trace: `npx playwright show-trace trace.zip`
3. CI deploys HTML report to Cloudflare Pages (link in PR comment)
4. Reproduce CI: `CI=true pnpm test:browser`
5. Local runs: `pnpm test:browser:local`
## Anti-Patterns
@@ -140,7 +141,6 @@ test.describe('FeatureName', { tag: ['@canvas'] }, () => {
test('should do something', async ({ comfyPage }) => {
await comfyPage.workflow.loadWorkflow('myWorkflow')
await comfyPage.nextFrame()
const node = (await comfyPage.nodeOps.getNodeRefsByTitle('KSampler'))[0]
// ... test logic

6
browser_tests/AGENTS.md
View File

@@ -36,12 +36,6 @@ browser_tests/
- Run `pnpm exec eslint browser_tests/path/to/file.ts` to lint specific files
- Run `pnpm exec oxlint browser_tests/path/to/file.ts` to check with oxlint
## After Making Changes
- Run `pnpm typecheck:browser` after modifying TypeScript files in this directory
- Run `pnpm exec eslint browser_tests/path/to/file.ts` to lint specific files
- Run `pnpm exec oxlint browser_tests/path/to/file.ts` to check with oxlint
## Skill Documentation
A Playwright test-writing skill exists at `.claude/skills/writing-playwright-tests/SKILL.md`.