Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 14:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test): use data-state=open to scope Reka UI context menu

Browse Source 
:visible pseudo-selector does not filter Reka UI menus correctly.
Use [data-state=open] which Reka UI sets on the active ContextMenuContent.
Also use .first() on menuitem queries as a safety net.
This commit is contained in:
dante01yoon
2026-04-01 18:42:01 +09:00
parent 447783e40e
commit 14cb85873f
1 changed files with 13 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
browser_tests/tests/topbar/workflowTabs.spec.ts
View File

@@ -66,15 +66,17 @@ test.describe('Workflow tabs', () => {
await topbar.getTab(0).click({ button: 'right' })
// Each tab has its own ContextMenuRoot; only one is visible at a time
const contextMenu = comfyPage.page.locator('[role="menu"]:visible')
// Reka UI ContextMenuContent gets data-state="open" when active
const contextMenu = comfyPage.page.locator(
'[role="menu"][data-state="open"]'
)
await expect(contextMenu).toBeVisible({ timeout: 5000 })
await expect(
contextMenu.getByRole('menuitem', { name: /Close Tab/i })
contextMenu.getByRole('menuitem', { name: /Close Tab/i }).first()
).toBeVisible()
await expect(
contextMenu.getByRole('menuitem', { name: /Save/i })
contextMenu.getByRole('menuitem', { name: /Save/i }).first()
).toBeVisible()
})
@@ -87,10 +89,15 @@ test.describe('Workflow tabs', () => {
await expect.poll(() => topbar.getTabNames()).toHaveLength(2)
await topbar.getTab(1).click({ button: 'right' })
const contextMenu = comfyPage.page.locator('[role="menu"]:visible')
const contextMenu = comfyPage.page.locator(
'[role="menu"][data-state="open"]'
)
await expect(contextMenu).toBeVisible({ timeout: 5000 })
await contextMenu.getByRole('menuitem', { name: /Close Tab/i }).click()
await contextMenu
.getByRole('menuitem', { name: /Close Tab/i })
.first()
.click()
await expect.poll(() => topbar.getTabNames()).toHaveLength(1)
})