fix: address CodeRabbit review feedback

- Use dynamic variant for TreeExplorerTreeNode badge to prevent
  multi-digit count truncation
- Add BadgeVariants return type to getEventSeverity for type safety
- Add explicit variant="dot" on AssetCard indicator badge
- Remove unrelated browser_tests files from commit
This commit is contained in:
dante01yoon
2026-03-24 20:21:21 +09:00
parent 9d72372ed6
commit 190e1442d9
6 changed files with 6 additions and 164 deletions

View File

@@ -1,139 +0,0 @@
{
"id": "b7e1a3f0-text-bleed-test",
"revision": 0,
"last_node_id": 2,
"last_link_id": 0,
"nodes": [
{
"id": 1,
"type": "CLIPTextEncode",
"pos": [500, 300],
"size": [240, 155],
"flags": {},
"order": 0,
"mode": 0,
"inputs": [
{
"localized_name": "clip",
"name": "clip",
"type": "CLIP",
"link": null
},
{
"localized_name": "text",
"name": "text",
"type": "STRING",
"widget": { "name": "text" },
"link": null
}
],
"outputs": [
{
"localized_name": "CONDITIONING",
"name": "CONDITIONING",
"type": "CONDITIONING",
"links": null
}
],
"properties": { "Node name for S&R": "CLIPTextEncode" },
"widgets_values": ["beautiful scenery nature glass bottle landscape"]
},
{
"id": 2,
"type": "KSampler",
"pos": [500, 300],
"size": [428, 437],
"flags": {},
"order": 1,
"mode": 0,
"inputs": [
{
"localized_name": "model",
"name": "model",
"type": "MODEL",
"link": null
},
{
"localized_name": "positive",
"name": "positive",
"type": "CONDITIONING",
"link": null
},
{
"localized_name": "negative",
"name": "negative",
"type": "CONDITIONING",
"link": null
},
{
"localized_name": "latent_image",
"name": "latent_image",
"type": "LATENT",
"link": null
},
{
"localized_name": "seed",
"name": "seed",
"type": "INT",
"widget": { "name": "seed" },
"link": null
},
{
"localized_name": "steps",
"name": "steps",
"type": "INT",
"widget": { "name": "steps" },
"link": null
},
{
"localized_name": "cfg",
"name": "cfg",
"type": "FLOAT",
"widget": { "name": "cfg" },
"link": null
},
{
"localized_name": "sampler_name",
"name": "sampler_name",
"type": "COMBO",
"widget": { "name": "sampler_name" },
"link": null
},
{
"localized_name": "scheduler",
"name": "scheduler",
"type": "COMBO",
"widget": { "name": "scheduler" },
"link": null
},
{
"localized_name": "denoise",
"name": "denoise",
"type": "FLOAT",
"widget": { "name": "denoise" },
"link": null
}
],
"outputs": [
{
"localized_name": "LATENT",
"name": "LATENT",
"type": "LATENT",
"links": null
}
],
"properties": { "Node name for S&R": "KSampler" },
"widgets_values": [0, "randomize", 20, 8, "euler", "simple", 1]
}
],
"links": [],
"groups": [],
"config": {},
"extra": {
"ds": {
"scale": 1,
"offset": [-200, -100]
}
},
"version": 0.4
}

View File

@@ -1,23 +0,0 @@
import {
comfyExpect as expect,
comfyPageFixture as test
} from '../../../../fixtures/ComfyPage'
import { fitToViewInstant } from '../../../../helpers/fitToView'
test.describe('Vue Node Text Bleed-Through', { tag: '@screenshot' }, () => {
test.beforeEach(async ({ comfyPage }) => {
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Disabled')
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
await comfyPage.workflow.loadWorkflow('vueNodes/overlapping-with-text')
await comfyPage.vueNodes.waitForNodes()
await fitToViewInstant(comfyPage)
})
test('overlapping node should not show text from node beneath', async ({
comfyPage
}) => {
await expect(comfyPage.canvas).toHaveScreenshot(
'node-text-no-bleed-through.png'
)
})
})

View File

@@ -25,7 +25,7 @@
v-if="showNodeBadgeText"
:label="nodeBadgeText"
severity="secondary"
variant="circle"
:variant="nodeBadgeText.length > 1 ? 'label' : 'circle'"
class="ml-2"
/>
</div>

View File

@@ -122,6 +122,7 @@
<Badge
v-if="isNewlyImported"
severity="contrast"
variant="dot"
class="absolute -top-0.5 -right-0.5"
/>
</Button>

View File

@@ -2,6 +2,7 @@ import type { AxiosError, AxiosResponse } from 'axios'
import axios from 'axios'
import { ref, watch } from 'vue'
import type { BadgeVariants } from '@/components/common/badge.variants'
import { getComfyApiBaseUrl } from '@/config/comfyApi'
import { d } from '@/i18n'
import { useFirebaseAuthStore } from '@/stores/firebaseAuthStore'
@@ -133,7 +134,9 @@ export const useCustomerEventsService = () => {
return value
}
function getEventSeverity(eventType: string) {
function getEventSeverity(
eventType: string
): NonNullable<BadgeVariants['severity']> {
switch (eventType) {
case 'credit_added':
return 'default'