mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-19 22:09:37 +00:00
fix: correct disconnect dispatch args, import typo, and test timeout
- LGraphNode: use link_info.origin_slot instead of array index for sourceSlotIndex in dispatchDisconnectNodePair - SubgraphInputNode: pass node input slot instead of subgraphInput for INPUT disconnect dispatch - SubgraphIO.test: fix double slash in import path - NightlySurveyPopover.test: remove unnecessary 15000ms timeout on fake-timer test Amp-Thread-ID: https://ampcode.com/threads/T-019c9bcb-2c95-712d-8978-ab8e9e688e4d Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
@@ -3235,7 +3235,7 @@ export class LGraphNode
|
||||
|
||||
graphLifecycleEventDispatcher.dispatchDisconnectNodePair({
|
||||
sourceNode: target_node,
|
||||
sourceSlotIndex: i,
|
||||
sourceSlotIndex: link_info.origin_slot,
|
||||
sourceSlot: output,
|
||||
targetNode: this,
|
||||
targetSlotIndex: slot,
|
||||
|
||||
@@ -7,8 +7,10 @@ import {
|
||||
SUBGRAPH_INPUT_ID,
|
||||
SUBGRAPH_OUTPUT_ID
|
||||
} from '@/lib/litegraph/src/constants'
|
||||
import { LinkDirection } from '@/lib/litegraph/src//types/globalEnums'
|
||||
import { NodeSlotType } from '@/lib/litegraph/src/types/globalEnums'
|
||||
import {
|
||||
LinkDirection,
|
||||
NodeSlotType
|
||||
} from '@/lib/litegraph/src/types/globalEnums'
|
||||
import { createUuidv4 } from '@/lib/litegraph/src/utils/uuid'
|
||||
|
||||
import { subgraphTest } from './__fixtures__/subgraphFixtures'
|
||||
@@ -169,7 +171,7 @@ describe('SubgraphIO - Input Slot Dual-Nature Behavior', () => {
|
||||
0,
|
||||
false,
|
||||
link,
|
||||
subgraphInput
|
||||
internalNode.inputs[0]
|
||||
)
|
||||
expect(internalNode.inputs[0].link).toBeNull()
|
||||
expect(subgraphInput.linkIds).toEqual([])
|
||||
|
||||
@@ -209,7 +209,7 @@ export class SubgraphInputNode
|
||||
slotIndex,
|
||||
connected: false,
|
||||
link,
|
||||
slot: subgraphInput
|
||||
slot: input
|
||||
})
|
||||
}
|
||||
|
||||
|
||||
@@ -90,7 +90,7 @@ describe('NightlySurveyPopover', () => {
|
||||
await nextTick()
|
||||
|
||||
expect(wrapper.find(POPOVER_SELECTOR).exists()).toBe(true)
|
||||
}, 15000)
|
||||
})
|
||||
|
||||
it('does not show when not eligible', async () => {
|
||||
setFeatureUsage('test-feature', 1)
|
||||
|
||||
Reference in New Issue
Block a user