Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-03 04:00:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

[Bug] Fix slot link state corruption on moving link between sockets (#882)

Browse Source 
Ref: https://github.com/Comfy-Org/litegraph.js/issues/881

This PR fixes the corrupted link state when moving link from one input
socket to another.
This commit is contained in:
Chenlei Hu
2025-04-04 14:28:41 -04:00
committed by GitHub
parent d17b86a6b8
commit 29c923e0e3
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/canvas/MovingInputLink.ts
View File

@@ -42,6 +42,7 @@ export class MovingInputLink extends MovingLinkBase {
connectToInput(inputNode: LGraphNode, input: INodeInputSlot, events: LinkConnectorEventTarget): LLink | null | undefined {
if (input === this.inputSlot) return
this.inputNode.disconnectInput(this.inputIndex, true)
const link = this.outputNode.connectSlots(this.outputSlot, inputNode, input, this.fromReroute?.id)
if (link) events.dispatch("input-moved", this)
return link

5
test/LinkConnector.integration.test.ts
View File

@@ -165,9 +165,7 @@ describe("LinkConnector Integration", () => {
})
describe("Moving input links", () => {
// Fails link integrity check. Original link is not properly removed.
// https://github.com/Comfy-Org/litegraph.js/issues/881
test.skip("Should move input links", ({ graph, connector }) => {
test("Should move input links", ({ graph, connector }) => {
const nextLinkId = graph.last_link_id + 1
const hasInputNode = graph.getNodeById(2)!
@@ -190,6 +188,7 @@ describe("LinkConnector Integration", () => {
expect(connector.inputLinks.length).toBe(0)
expect(disconnectedNode.inputs[0].link).toBe(nextLinkId)
expect(hasInputNode.inputs[0].link).toBeNull()
const reroutesAfter = LLink.getReroutes(graph, graph.links.get(disconnectedNode.inputs[0].link!)!)
expect(reroutesAfter).toEqual(reroutesBefore)