Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 14:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: use textarea.labels for deterministic label lookup in test

Browse Source
This commit is contained in:
bymyself
2026-03-16 06:08:12 -07:00
parent 83e685b0fc
commit 2fd8be90cf
1 changed files with 6 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
browser_tests/tests/vueNodes/widgets/text/textareaLabelOverlap.spec.ts
View File

@@ -16,9 +16,6 @@ test.describe('Textarea label overlap', { tag: ['@widget'] }, () => {
const getTextarea = (comfyPage: ComfyPage) =>
getFirstClipNode(comfyPage).getByRole('textbox', { name: 'text' })
const getLabel = (comfyPage: ComfyPage) =>
getFirstClipNode(comfyPage).locator('label')
test('label should have a background color to prevent text showing through when scrolled', async ({
comfyPage
}) => {
@@ -31,14 +28,12 @@ test.describe('Textarea label overlap', { tag: ['@widget'] }, () => {
).join('\n')
await textarea.fill(manyLines)
const label = getLabel(comfyPage)
await expect(label).toBeVisible()
// The label must have a non-transparent background so scrolled text
// does not show through it.
const bgColor = await label.evaluate(
(el) => getComputedStyle(el).backgroundColor
)
// The label associated with this textarea must have a non-transparent
// background so scrolled text does not show through it.
const bgColor = await textarea.evaluate((el) => {
const label = (el as HTMLTextAreaElement).labels?.[0]
return label ? getComputedStyle(label).backgroundColor : ''
})
// 'transparent' or 'rgba(0, 0, 0, 0)' means no background — the bug.
expect(