Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-26 17:54:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: correct selectNodes multi-selection and tab name assertions

Browse Source 
Amp-Thread-ID: https://ampcode.com/threads/T-019c17a0-1d8c-746f-8ee0-0145b7f56561
This commit is contained in:
bymyself
2026-01-31 21:27:08 -08:00
parent 337e71dce2
commit 32694573a9
3 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
browser_tests/fixtures/ComfyPage.ts
View File

@@ -1373,14 +1373,18 @@ export class ComfyPage {
}
async selectNodes(nodeTitles: string[]) {
await this.page.keyboard.down('Control')
let isFirst = true
for (const nodeTitle of nodeTitles) {
const nodes = await this.getNodeRefsByTitle(nodeTitle)
for (const node of nodes) {
await node.click('title')
if (isFirst) {
await node.click('title')
isFirst = false
} else {
await node.click('title', { modifiers: ['Control'] })
}
}
}
await this.page.keyboard.up('Control')
await this.nextFrame()
}

6
browser_tests/tests/propertiesPanel/propertiesPanelBasic.spec.ts
View File

@@ -125,19 +125,19 @@ test.describe('Properties panel basic functionality', { tag: ['@ui'] }, () => {
await expect(propertiesPanel.panelTitle).toContainText('items selected')
})
test('shows Parameters and Settings tabs for multiple selection', async ({
test('shows Nodes and Settings tabs for multiple selection', async ({
comfyPage
}) => {
const { propertiesPanel } = comfyPage
await comfyPage.selectNodes(['KSampler', 'VAE Decode'])
await expect(propertiesPanel.getTab('Parameters')).toBeVisible()
await expect(propertiesPanel.getTab('Nodes')).toBeVisible()
await expect(propertiesPanel.getTab('Settings')).toBeVisible()
await expect(propertiesPanel.getTab('Info')).not.toBeVisible()
})
test('lists all selected nodes in Parameters tab', async ({
test('lists all selected nodes in Nodes tab', async ({
comfyPage
}) => {
const { propertiesPanel } = comfyPage

4
browser_tests/tests/propertiesPanel/propertiesPanelTabs.spec.ts
View File

@@ -68,10 +68,10 @@ test.describe('Properties panel tab navigation', { tag: ['@ui'] }, () => {
await expect(propertiesPanel.getTab('Nodes')).not.toBeVisible()
await comfyPage.selectNodes(['KSampler', 'VAE Decode'])
await expect(propertiesPanel.getTab('Parameters')).toBeVisible()
await expect(propertiesPanel.getTab('Nodes')).toBeVisible()
await expect(propertiesPanel.getTab('Settings')).toBeVisible()
await expect(propertiesPanel.getTab('Info')).not.toBeVisible()
await expect(propertiesPanel.getTab('Nodes')).not.toBeVisible()
await expect(propertiesPanel.getTab('Parameters')).not.toBeVisible()
})
test('first tab updates for multiple selection', async ({ comfyPage }) => {