Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-05-24 22:58:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: wrap console.warn spy in try/finally for cleanup safety

Browse Source 
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
bymyself
2026-05-14 15:23:23 -07:00
parent 98b7934aa5
commit 42500d452e
1 changed files with 23 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/schemas/nodeDef/migration.test.ts
View File

@@ -634,29 +634,30 @@ describe('ComfyNodeDefImpl', () => {
it('should emit deprecation warning for optional input with defaultInput', () => {
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {})
try {
new ComfyNodeDefImpl({
name: 'TestNode',
display_name: 'Test Node',
category: 'Test',
python_module: 'test_module',
description: 'A test node',
input: {
optional: {
seed: ['INT', { defaultInput: true }]
}
},
output: [],
output_is_list: [],
output_name: [],
output_node: false
} as ComfyNodeDefV1)
new ComfyNodeDefImpl({
name: 'TestNode',
display_name: 'Test Node',
category: 'Test',
python_module: 'test_module',
description: 'A test node',
input: {
optional: {
seed: ['INT', { defaultInput: true }]
}
},
output: [],
output_is_list: [],
output_name: [],
output_node: false
} as ComfyNodeDefV1)
expect(warnSpy).toHaveBeenCalledWith(
'Use of defaultInput on optional input test_module:TestNode:seed is deprecated and ignored. Remove defaultInput. Use forceInput only if you intentionally want a socket-only input.'
)
warnSpy.mockRestore()
expect(warnSpy).toHaveBeenCalledWith(
'Use of defaultInput on optional input test_module:TestNode:seed is deprecated and ignored. Remove defaultInput. Use forceInput only if you intentionally want a socket-only input.'
)
} finally {
warnSpy.mockRestore()
}
})
it('should not mutate the original node definition', () => {