Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-08 17:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove some comments

Browse Source
This commit is contained in:
Simula_r
2025-10-20 14:52:28 -07:00
parent 7d4b9b3cfd
commit 44f91dc0a8
1 changed files with 0 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
src/renderer/extensions/vueNodes/composables/useFixVueNodeOverlap.ts
View File

@@ -6,36 +6,6 @@ import { app as comfyApp } from '@/scripts/app'
/* eslint-disable no-console */
//Problem. When switching from litegraph to vue nodes because the vue nodes are a new design they are arbitrarily and non uniformally different sized but all together larger than litegraph nodes. But they use the same posiiton as the litegraph nodes... so that means they can be overlapped. And for litegraph workflows where nodes are very close together the overlap can be often and severe because the vue nodes are much larger.
//Solution take the litegraph node positions and bounds and scale them proportionally from the center of the canvas before the switch to vue nodes.
//Implementation guide:
//Step 1: litegraph nodes pos and bounds to new array to work with
//Get all the nodes positions and bounds in litegraph and put them in a new array to work with. This array is called lgOriginalPosAndBounds
//Scale their positions and bounds proportionally from the center of the all nodes bounds
//Determine the right sclaing factor for now we can scale all of them by say 50% 1.5x
//For convenince assign new scaled pos and bounds to new array lgScaledPosAndBounds
//Step 2: iterate over the lgScaledPosAndBounds positions and move the vue nodes there.
//Loop over the lgScalePosAndBounds
//Loop over the layoutStore.getAllNodes().value
//For each lgScalePosAndBounds find the layoutStore.getAllNodes().value equivilent and move the node to the lgScalePosAndBounds position
//Acutally move the node using moveNode(nodeID, nodePos) from useLayoutMutations();
//Questions:
// 1. Q: how do we get litegraph nodes pos and bounds for every node cleanly and accurately in canvas space? A: Should be able to use comfyApp.canvas.graph.nodes
//How do we check lgScalePosAndBounds item is the same item as layoutStore.getAllNodes().value maybe we use nodeID? A: yes we can use graph.getNodeById()
//The before should be all the litegraph nodes exactly where they are
//The after should be all the litegraph nodes scaled proportionally from their center and the vue nodes moved to their positions.
//Next Problem. Groups are not handled by this function. So if there are groups within the workflow. We are not scaling them which means when the node positions change they often are outisdeo of the groups and then it looks broken. In othere words the problem is groups do not scale with nodes.
//Quesitons: How do groups work in litegraph. How can we get the node bounds? Can we just scale their position in the exact same way? Should be able to?
//Rough idea: We need to get all groups. Loop over them, read their Rect x and y and their width and height. And then after are done scaling the nodes posiitons we need to do the same for the groups but we also need to scale their width and height.
const SCALE_FACTOR = 1.5
export function useFixVueNodeOverlap() {