Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 06:20:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

Review feedback

Browse Source
This commit is contained in:
Austin Mroz
2026-03-30 13:40:29 -07:00
parent a8352964e3
commit 4a51735266
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
browser_tests/fixtures/helpers/BuilderSelectHelper.ts
View File

@@ -38,6 +38,10 @@ export class BuilderSelectHelper {
return this.comfyPage.page
}
get selectedItems(): Locator {
return this.page.getByTestId(TestIds.builder.ioItem)
}
/**
* Get the actions menu trigger for a builder IoItem (input-select sidebar).
* @param title The widget title shown in the IoItem.

15
browser_tests/tests/appModeBuilder.spec.ts
View File

@@ -2,22 +2,17 @@ import {
comfyPageFixture as test,
comfyExpect as expect
} from '../fixtures/ComfyPage'
import { TestIds } from '../fixtures/selectors'
test.describe('App mode builder selection', () => {
test.beforeEach(async ({ comfyPage }) => {
await comfyPage.featureFlags.setFlag('linear_toggle_enabled', true)
await comfyPage.settings.setSetting('Comfy.UseNewMenu', 'Top')
await comfyPage.settings.setSetting(
'Comfy.AppBuilder.VueNodeSwitchDismissed',
true
)
await comfyPage.settings.setSetting('Comfy.VueNodes.Enabled', true)
})
test('Can independently select inputs of same name', async ({
comfyPage
}) => {
const items = comfyPage.page.getByTestId(TestIds.builder.ioItem)
const items = comfyPage.appMode.select.selectedItems
await comfyPage.vueNodes.selectNodes(['6', '7'])
await comfyPage.command.executeCommand('Comfy.Graph.ConvertToSubgraph')
@@ -37,7 +32,7 @@ test.describe('App mode builder selection', () => {
}
})
test('Can drag and drop inputs', async ({ comfyPage }) => {
const items = comfyPage.page.getByTestId(TestIds.builder.ioItem)
const items = comfyPage.appMode.select.selectedItems
await comfyPage.appMode.enterBuilder()
await comfyPage.appMode.steps.goToInputs()
await expect(items).toHaveCount(0)
@@ -62,11 +57,11 @@ test.describe('App mode builder selection', () => {
const saveImage = await comfyPage.vueNodes.getNodeLocator('9')
await saveImage.click()
const items = comfyPage.page.getByTestId(TestIds.builder.ioItem)
const items = comfyPage.appMode.select.selectedItems
await expect(items).toHaveCount(1)
})
test('Can not select nodes with errors or notes', async ({ comfyPage }) => {
const items = comfyPage.page.getByTestId(TestIds.builder.ioItem)
const items = comfyPage.appMode.select.selectedItems
await comfyPage.appMode.enterBuilder()
await comfyPage.appMode.steps.goToInputs()
await expect(items).toHaveCount(0)