Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 06:20:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: prefer explicit qa-session.webm over corrupt auto-recorded videos

Browse Source 
The convert step was using find which picked up a 0-byte file from
playwright's videos/ directory instead of the valid qa-session.webm.
Now prefers qa-session.webm explicitly and skips empty files.
This commit is contained in:
snomiao
2026-03-18 22:31:54 +00:00
parent ca394b9ff7
commit 4f98518c22
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
.github/workflows/pr-qa.yaml vendored
View File

@@ -345,9 +345,15 @@ jobs:
run: |
for dir in qa-artifacts/qa-report-*; do
[ -d "$dir" ] || continue
WEBM=$(find "$dir" -name '*.webm' -type f | head -1)
# Prefer explicitly-saved qa-session.webm over auto-recorded files
if [ -f "$dir/qa-session.webm" ] && [ -s "$dir/qa-session.webm" ]; then
WEBM="$dir/qa-session.webm"
else
# Fallback: find any non-empty webm
WEBM=$(find "$dir" -name '*.webm' -type f -size +0c | head -1)
fi
if [ -z "$WEBM" ]; then
echo "No .webm video in $dir, skipping"
echo "No valid .webm video in $dir, skipping"
continue
fi
echo "Converting $WEBM ($(du -h "$WEBM" | cut -f1)) to mp4"