Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-08 17:10:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

[CodeHealth] Improve legibility of renderingBoxColor (#832)

Browse Source 
Drastically reduces the cognitive complexity of
`LGraphNode.renderingBoxColor` by impl. early returns.
This commit is contained in:
filtered
2025-03-23 08:53:42 +11:00
committed by GitHub
parent a44b8d0581
commit 642e73773c
1 changed files with 8 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/LGraphNode.ts
View File

@@ -223,20 +223,18 @@ export class LGraphNode implements Positionable, IPinnable, IColorable {
/** The box color used to render the node. */
get renderingBoxColor(): string {
const mode = this.mode ?? LGraphEventMode.ALWAYS
let colState = LiteGraph.node_box_coloured_by_mode && LiteGraph.NODE_MODES_COLORS[mode]
? LiteGraph.NODE_MODES_COLORS[mode]
: undefined
if (this.boxcolor) return this.boxcolor
if (LiteGraph.node_box_coloured_when_on) {
colState = this.action_triggered
? "#FFF"
: (this.execute_triggered
? "#AAA"
: colState)
if (this.action_triggered) return "#FFF"
if (this.execute_triggered) return "#AAA"
}
return this.boxcolor || colState || LiteGraph.NODE_DEFAULT_BOXCOLOR
if (LiteGraph.node_box_coloured_by_mode) {
const modeColour = LiteGraph.NODE_MODES_COLORS[this.mode ?? LGraphEventMode.ALWAYS]
if (modeColour) return modeColour
}
return LiteGraph.NODE_DEFAULT_BOXCOLOR
}
/** @inheritdoc {@link IColorable.setColorOption} */