Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-02 22:37:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[nit] Simplifiy node i/o slot loop (#496)

Browse Source
This commit is contained in:
Chenlei Hu
2025-02-08 22:35:18 -05:00
committed by GitHub
parent 7e76fd58a1
commit 64fddc078c
1 changed files with 55 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
src/LGraphCanvas.ts
View File

@@ -4712,75 +4712,71 @@ export class LGraphCanvas implements ConnectionColorContext {
// render inputs and outputs
if (!node.collapsed) {
// input connection slots
if (node.inputs) {
for (let i = 0; i < node.inputs.length; i++) {
const slot = toClass(NodeInputSlot, node.inputs[i])
for (const [i, input] of (node.inputs ?? []).entries()) {
const slot = toClass(NodeInputSlot, input)
// change opacity of incompatible slots when dragging a connection
const isValid =
!this.connecting_links ||
(out_slot && LiteGraph.isValidConnection(slot.type, out_slot.type))
const highlight = isValid && node.mouseOver?.inputId === i
const label_color = highlight
? highlightColour
: LiteGraph.NODE_TEXT_COLOR
ctx.globalAlpha = isValid ? editor_alpha : 0.4 * editor_alpha
// change opacity of incompatible slots when dragging a connection
const isValid =
!this.connecting_links ||
(out_slot && LiteGraph.isValidConnection(slot.type, out_slot.type))
const highlight = isValid && node.mouseOver?.inputId === i
const label_color = highlight
? highlightColour
: LiteGraph.NODE_TEXT_COLOR
ctx.globalAlpha = isValid ? editor_alpha : 0.4 * editor_alpha
const pos = node.getConnectionPos(true, i, slot_pos)
pos[0] -= node.pos[0]
pos[1] -= node.pos[1]
if (max_y < pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5) {
max_y = pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5
}
slot.draw(ctx, {
pos,
colorContext: this,
labelColor: label_color,
labelPosition: LabelPosition.Right,
horizontal,
lowQuality: low_quality,
renderText: render_text,
highlight,
})
const pos = node.getConnectionPos(true, i, slot_pos)
pos[0] -= node.pos[0]
pos[1] -= node.pos[1]
if (max_y < pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5) {
max_y = pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5
}
slot.draw(ctx, {
pos,
colorContext: this,
labelColor: label_color,
labelPosition: LabelPosition.Right,
horizontal,
lowQuality: low_quality,
renderText: render_text,
highlight,
})
}
// output connection slots
if (node.outputs) {
for (let i = 0; i < node.outputs.length; i++) {
const slot = toClass(NodeOutputSlot, node.outputs[i])
for (const [i, output] of (node.outputs ?? []).entries()) {
const slot = toClass(NodeOutputSlot, output)
const slot_type = slot.type
const slot_type = slot.type
// change opacity of incompatible slots when dragging a connection
const isValid =
!this.connecting_links ||
(in_slot && LiteGraph.isValidConnection(slot_type, in_slot.type))
const highlight = isValid && node.mouseOver?.outputId === i
const label_color = highlight
? highlightColour
: LiteGraph.NODE_TEXT_COLOR
ctx.globalAlpha = isValid ? editor_alpha : 0.4 * editor_alpha
// change opacity of incompatible slots when dragging a connection
const isValid =
!this.connecting_links ||
(in_slot && LiteGraph.isValidConnection(slot_type, in_slot.type))
const highlight = isValid && node.mouseOver?.outputId === i
const label_color = highlight
? highlightColour
: LiteGraph.NODE_TEXT_COLOR
ctx.globalAlpha = isValid ? editor_alpha : 0.4 * editor_alpha
const pos = node.getConnectionPos(false, i, slot_pos)
pos[0] -= node.pos[0]
pos[1] -= node.pos[1]
if (max_y < pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5) {
max_y = pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5
}
slot.draw(ctx, {
pos,
colorContext: this,
labelColor: label_color,
labelPosition: LabelPosition.Left,
horizontal,
lowQuality: low_quality,
renderText: render_text,
highlight,
})
const pos = node.getConnectionPos(false, i, slot_pos)
pos[0] -= node.pos[0]
pos[1] -= node.pos[1]
if (max_y < pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5) {
max_y = pos[1] + LiteGraph.NODE_SLOT_HEIGHT * 0.5
}
slot.draw(ctx, {
pos,
colorContext: this,
labelColor: label_color,
labelPosition: LabelPosition.Left,
horizontal,
lowQuality: low_quality,
renderText: render_text,
highlight,
})
}
ctx.textAlign = "left"