mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-02 14:27:40 +00:00
Fix: Cloud notification badge reactivity and modal timing
- Fix badge not appearing by accessing settingStore.settingValues directly for proper reactivity - Increase modal delay to 2s to ensure it appears after missing models dialog - Move setting update inside setTimeout to only save when modal actually shows 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
24
src/App.vue
24
src/App.vue
@@ -80,15 +80,23 @@ onMounted(async () => {
|
||||
void conflictDetection.initializeConflictDetection()
|
||||
|
||||
// Show cloud notification for macOS desktop users (one-time)
|
||||
const isMacOS = navigator.platform.toLowerCase().includes('mac')
|
||||
const settingStore = useSettingStore()
|
||||
const hasShownNotification = settingStore.get(
|
||||
'Comfy.Desktop.CloudNotificationShown'
|
||||
)
|
||||
// Delayed to ensure it appears after workflow loading (missing models dialog, etc.)
|
||||
if (isElectron()) {
|
||||
const isMacOS = navigator.platform.toLowerCase().includes('mac')
|
||||
if (isMacOS) {
|
||||
const settingStore = useSettingStore()
|
||||
const hasShownNotification = settingStore.get(
|
||||
'Comfy.Desktop.CloudNotificationShown'
|
||||
)
|
||||
|
||||
if (isElectron() && isMacOS && !hasShownNotification) {
|
||||
dialogService.showCloudNotification()
|
||||
await settingStore.set('Comfy.Desktop.CloudNotificationShown', true)
|
||||
if (!hasShownNotification) {
|
||||
// Delay to show after initial workflow loading completes
|
||||
setTimeout(async () => {
|
||||
dialogService.showCloudNotification()
|
||||
await settingStore.set('Comfy.Desktop.CloudNotificationShown', true)
|
||||
}, 2000)
|
||||
}
|
||||
}
|
||||
}
|
||||
})
|
||||
</script>
|
||||
|
||||
@@ -72,8 +72,10 @@ const dialogService = useDialogService()
|
||||
|
||||
const isMacOS = computed(() => navigator.platform.toLowerCase().includes('mac'))
|
||||
|
||||
const hasShownNotification = computed(() =>
|
||||
settingStore.get('Comfy.Desktop.CloudNotificationShown')
|
||||
// Access the reactive store state directly for proper reactivity
|
||||
const hasShownNotification = computed(
|
||||
() =>
|
||||
settingStore.settingValues['Comfy.Desktop.CloudNotificationShown'] ?? false
|
||||
)
|
||||
|
||||
const shouldShowCloudBadge = computed(
|
||||
|
||||
Reference in New Issue
Block a user