mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-02-03 06:47:33 +00:00
fix: improve error handling in Playwright tests
- Remove unnecessary .catch(() => {}) in userSelectView test that was
hiding potential failures
- Add explanatory comments for legitimate .catch(() => {}) usage in
cleanup blocks of linkInteraction tests
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
@@ -43,7 +43,7 @@ test.describe('User Select View', () => {
|
||||
|
||||
// Try to click first option if it exists
|
||||
const firstOption = page.locator('.p-select-list .p-select-option').first()
|
||||
await firstOption.waitFor({ state: 'visible' }).catch(() => {})
|
||||
await firstOption.waitFor({ state: 'visible', timeout: 5000 })
|
||||
|
||||
if ((await firstOption.count()) > 0) {
|
||||
await firstOption.click()
|
||||
|
||||
@@ -300,6 +300,7 @@ test.describe('Vue Node Link Interaction', () => {
|
||||
'vue-node-input-drag-ctrl-alt.png'
|
||||
)
|
||||
} finally {
|
||||
// Cleanup operations: silently ignore errors if state is already clean
|
||||
await comfyMouse.drop().catch(() => {})
|
||||
await comfyPage.page.keyboard.up('Alt').catch(() => {})
|
||||
await comfyPage.page.keyboard.up('Control').catch(() => {})
|
||||
@@ -467,6 +468,7 @@ test.describe('Vue Node Link Interaction', () => {
|
||||
await comfyMouse.drop()
|
||||
dropped = true
|
||||
} finally {
|
||||
// Cleanup: ensure mouse is released if drop failed
|
||||
if (!dropped) {
|
||||
await comfyMouse.drop().catch(() => {})
|
||||
}
|
||||
@@ -557,6 +559,7 @@ test.describe('Vue Node Link Interaction', () => {
|
||||
await comfyMouse.drop()
|
||||
dropPending = false
|
||||
} finally {
|
||||
// Cleanup: ensure mouse and keyboard are released if test fails
|
||||
if (dropPending) await comfyMouse.drop().catch(() => {})
|
||||
if (shiftHeld) await comfyPage.page.keyboard.up('Shift').catch(() => {})
|
||||
}
|
||||
@@ -689,6 +692,7 @@ test.describe('Vue Node Link Interaction', () => {
|
||||
'vue-node-shift-output-multi-link.png'
|
||||
)
|
||||
} finally {
|
||||
// Cleanup: ensure mouse and keyboard are released if test fails
|
||||
if (dropPending) await comfyMouse.drop().catch(() => {})
|
||||
if (shiftHeld) await comfyPage.page.keyboard.up('Shift').catch(() => {})
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user