refactor: remove unused widgetValueStore methods

Remove unregistration and filtering methods that are not currently used:
- unregisterWidget, unregisterNode
- getVisibleWidgets, getAdvancedWidgets, getPromotedWidgets
- widgetStates (no longer exported)

Amp-Thread-ID: https://ampcode.com/threads/T-019c2cf2-feaa-75e8-a16f-dae7f38ada8b
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
Alexander Brown
2026-02-05 00:38:03 -08:00
parent 2288c259d0
commit 88eb8644af
2 changed files with 1 additions and 90 deletions

View File

@@ -94,28 +94,6 @@ describe('useWidgetValueStore', () => {
expect(state.serialize).toBe(false)
expect(state.options).toEqual({ multiline: true })
})
it('unregisters a widget', () => {
const store = useWidgetValueStore()
store.registerWidget(widget('node-1', 'seed', 'number', 100))
store.unregisterWidget('node-1', 'seed')
expect(store.getWidget('node-1', 'seed')).toBeUndefined()
})
it('unregisters all widgets for a node', () => {
const store = useWidgetValueStore()
store.registerWidget(widget('node-1', 'seed', 'number', 1))
store.registerWidget(widget('node-1', 'steps', 'number', 20))
store.registerWidget(widget('node-2', 'seed', 'number', 2))
store.unregisterNode('node-1')
expect(store.getWidget('node-1', 'seed')).toBeUndefined()
expect(store.getWidget('node-1', 'steps')).toBeUndefined()
expect(store.getWidget('node-2', 'seed')?.value).toBe(2)
})
})
describe('widget getters', () => {
@@ -144,45 +122,6 @@ describe('useWidgetValueStore', () => {
expect(widgets).toHaveLength(2)
expect(widgets.map((w) => w.name).sort()).toEqual(['seed', 'steps'])
})
it('getVisibleWidgets filters out hidden widgets', () => {
const store = useWidgetValueStore()
store.registerWidget(widget('node-1', 'visible', 'number', 1))
store.registerWidget(
widget('node-1', 'hidden', 'number', 2, { hidden: true })
)
const visible = store.getVisibleWidgets('node-1')
expect(visible).toHaveLength(1)
expect(visible[0].name).toBe('visible')
})
it('getAdvancedWidgets returns only advanced widgets', () => {
const store = useWidgetValueStore()
store.registerWidget(widget('node-1', 'basic', 'number', 1))
store.registerWidget(
widget('node-1', 'adv1', 'number', 2, { advanced: true })
)
store.registerWidget(
widget('node-1', 'adv2', 'string', 'x', { advanced: true })
)
const advanced = store.getAdvancedWidgets('node-1')
expect(advanced).toHaveLength(2)
expect(advanced.map((w) => w.name).sort()).toEqual(['adv1', 'adv2'])
})
it('getPromotedWidgets returns only promoted widgets', () => {
const store = useWidgetValueStore()
store.registerWidget(widget('node-1', 'normal', 'number', 1))
store.registerWidget(
widget('node-1', 'promo', 'string', 'x', { promoted: true })
)
const promoted = store.getPromotedWidgets('node-1')
expect(promoted).toHaveLength(1)
expect(promoted[0].name).toBe('promo')
})
})
describe('direct property mutation', () => {

View File

@@ -57,10 +57,6 @@ export const useWidgetValueStore = defineStore('widgetValue', () => {
return widgetStates.value.get(key) as WidgetState<TValue>
}
function unregisterWidget(nodeId: NodeId, widgetName: string): void {
widgetStates.value.delete(makeKey(nodeId, widgetName))
}
function getNodeWidgets(nodeId: NodeId): WidgetState[] {
const prefix = `${nodeId}:`
return [...widgetStates.value]
@@ -68,12 +64,6 @@ export const useWidgetValueStore = defineStore('widgetValue', () => {
.map(([, state]) => state)
}
function unregisterNode(nodeId: NodeId): void {
for (const { name } of getNodeWidgets(nodeId)) {
widgetStates.value.delete(makeKey(nodeId, name))
}
}
function getWidget(
nodeId: NodeId,
widgetName: string
@@ -81,27 +71,9 @@ export const useWidgetValueStore = defineStore('widgetValue', () => {
return widgetStates.value.get(makeKey(nodeId, widgetName))
}
function getVisibleWidgets(nodeId: NodeId): WidgetState[] {
return getNodeWidgets(nodeId).filter((w) => !w.hidden)
}
function getAdvancedWidgets(nodeId: NodeId): WidgetState[] {
return getNodeWidgets(nodeId).filter((w) => w.advanced)
}
function getPromotedWidgets(nodeId: NodeId): WidgetState[] {
return getNodeWidgets(nodeId).filter((w) => w.promoted)
}
return {
widgetStates,
registerWidget,
unregisterWidget,
unregisterNode,
getWidget,
getNodeWidgets,
getVisibleWidgets,
getAdvancedWidgets,
getPromotedWidgets
getNodeWidgets
}
})