mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
fix: remove PREPARING/ANALYZING intermediate badge deploys
Root cause: Cloudflare Pages serves stale deployments when multiple deploys race to the same branch. The ANALYZING placeholder deployed seconds before the final report would sometimes 'win' the race. Fix: Only deploy once — the final report with the real badge. No more intermediate PREPARING or ANALYZING placeholders. Amp-Thread-ID: https://ampcode.com/threads/T-019d4786-eb5f-7115-a10e-5b086c921800 Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
14
.github/workflows/pr-qa.yaml
vendored
14
.github/workflows/pr-qa.yaml
vendored
@@ -687,14 +687,6 @@ jobs:
|
||||
[ -n "$NUM" ] && LABEL="#${NUM} QA"
|
||||
echo "badge_label=${LABEL}" >> "$GITHUB_OUTPUT"
|
||||
|
||||
- name: Deploy placeholder page — PREPARING
|
||||
env:
|
||||
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
|
||||
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
|
||||
BADGE_LABEL: ${{ steps.pr.outputs.badge_label || 'QA' }}
|
||||
RUN_URL: ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}
|
||||
run: /tmp/deploy-badge.sh "PREPARING" "#2196f3" "$BADGE_LABEL" "$RUN_URL"
|
||||
|
||||
- name: Checkout repository
|
||||
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
|
||||
|
||||
@@ -800,12 +792,6 @@ jobs:
|
||||
fi
|
||||
done
|
||||
|
||||
- name: Deploy badge — ANALYZING
|
||||
env:
|
||||
CLOUDFLARE_API_TOKEN: ${{ secrets.CLOUDFLARE_API_TOKEN }}
|
||||
CLOUDFLARE_ACCOUNT_ID: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
|
||||
run: /tmp/deploy-badge.sh "ANALYZING" "#ff9800" "${{ steps.pr.outputs.badge_label || 'QA' }}" "${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}"
|
||||
|
||||
- name: Build context for video review
|
||||
env:
|
||||
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
||||
|
||||
Reference in New Issue
Block a user