Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-03-03 12:10:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: soften gotchas table language to avoid blocking diagnostics

Browse Source 
Amp-Thread-ID: https://ampcode.com/threads/T-019c2f99-6c3b-701e-8f90-4f897ecf85d8
This commit is contained in:
bymyself
2026-02-05 13:01:06 -08:00
parent 475ba0517a
commit 918c6c3687
1 changed files with 12 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
.claude/skills/writing-playwright-tests/SKILL.md
View File

@@ -40,17 +40,19 @@ const BYPASS_CLASS = /before:bg-bypass\/60/
await expect(node).toHaveClass(BYPASS_CLASS)
```
## Critical Gotchas
## Common Issues
| Issue | Symptom | Fix |
| ----------------------- | ---------------------------------- | -------------------------------------------------------------------------------------- |
| **Missing nextFrame()** | Test passes locally, fails in CI | Add `await comfyPage.nextFrame()` after canvas ops (not needed after `loadWorkflow()`) |
| **Missing focus** | Keyboard shortcuts don't work | Add `await comfyPage.canvas.click()` first |
| **Double-click timing** | Double-click doesn't trigger | Add `{ delay: 5 }` option |
| **Drag animation** | Elements end up in wrong position | Use `{ steps: 10 }` not `{ steps: 1 }` |
| **Upload incomplete** | Widget value wrong after drag-drop | Add `{ waitForUpload: true }` |
| **Test pollution** | Test fails when run with others | Add `afterEach` with `resetView()` |
| **Screenshot mismatch** | Local screenshots don't match CI | Screenshots are Linux-only, use PR label |
These are frequent causes of flaky tests - check them first, but investigate if they don't apply:
| Symptom | Common Cause | Typical Fix |
| ---------------------------------- | ------------------------- | -------------------------------------------------------------------------------------- |
| Test passes locally, fails in CI | Missing nextFrame() | Add `await comfyPage.nextFrame()` after canvas ops (not needed after `loadWorkflow()`) |
| Keyboard shortcuts don't work | Missing focus | Add `await comfyPage.canvas.click()` first |
| Double-click doesn't trigger | Timing too fast | Add `{ delay: 5 }` option |
| Elements end up in wrong position | Drag animation incomplete | Use `{ steps: 10 }` not `{ steps: 1 }` |
| Widget value wrong after drag-drop | Upload incomplete | Add `{ waitForUpload: true }` |
| Test fails when run with others | Test pollution | Add `afterEach` with `resetView()` |
| Local screenshots don't match CI | Platform differences | Screenshots are Linux-only, use PR label |
## Test Tags