Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-19 22:09:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: badge FINISHED state includes result sub-state

Browse Source 
FINISHED is not standalone — always shows result:
- FINISHED: REPRODUCED / NOT REPRODUCIBLE / PARTIAL (issues)
- FINISHED: APPROVED / MAJOR ISSUES / MINOR ISSUES (PRs)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
snomiao
2026-03-25 14:25:53 +09:00
parent 861cb7a782
commit 928db261f4
1 changed files with 18 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

34
.github/workflows/pr-qa.yaml vendored
View File

@@ -1021,31 +1021,33 @@ jobs:
ERROREOF
# Generate badge SVG into deploy dir (served as /badge.svg)
BADGE_STATUS="FINISHED"
# Determine result sub-state from video review reports
RESULT=""
BADGE_COLOR="#4c1"
# Determine final status from video review reports
if grep -riq 'not reproduced\|could not reproduce\|unable to reproduce' video-reviews/ 2>/dev/null; then
BADGE_STATUS="NOT REPRODUCIBLE"
BADGE_COLOR="#9f9f9f"
elif grep -riq 'partially reproduced\|partial' video-reviews/ 2>/dev/null; then
BADGE_STATUS="PARTIAL"
BADGE_COLOR="#dfb317"
elif grep -riq 'reproduced\|confirmed' video-reviews/ 2>/dev/null; then
BADGE_STATUS="REPRODUCED"
BADGE_COLOR="#e05d44"
fi
if [ "$TARGET_TYPE" != "issue" ]; then
if [ "$TARGET_TYPE" = "issue" ]; then
if grep -riq 'not reproduced\|could not reproduce\|unable to reproduce' video-reviews/ 2>/dev/null; then
RESULT="NOT REPRODUCIBLE"
BADGE_COLOR="#9f9f9f"
elif grep -riq 'partially reproduced\|partial' video-reviews/ 2>/dev/null; then
RESULT="PARTIAL"
BADGE_COLOR="#dfb317"
elif grep -riq 'reproduced\|confirmed' video-reviews/ 2>/dev/null; then
RESULT="REPRODUCED"
BADGE_COLOR="#e05d44"
fi
else
if grep -riq 'major.*issue\|critical\|breaking\|regression' video-reviews/ 2>/dev/null; then
BADGE_STATUS="MAJOR ISSUES"
RESULT="MAJOR ISSUES"
BADGE_COLOR="#e05d44"
elif grep -riq 'minor.*issue\|cosmetic\|nitpick' video-reviews/ 2>/dev/null; then
BADGE_STATUS="MINOR ISSUES"
RESULT="MINOR ISSUES"
BADGE_COLOR="#dfb317"
elif grep -riq 'no.*issue\|looks good\|approved\|pass' video-reviews/ 2>/dev/null; then
BADGE_STATUS="APPROVED"
RESULT="APPROVED"
BADGE_COLOR="#4c1"
fi
fi
BADGE_STATUS="FINISHED${RESULT:+: ${RESULT}}"
/tmp/gen-badge.sh "$BADGE_STATUS" "$BADGE_COLOR" "$DEPLOY_DIR/badge.svg"
echo "badge_status=${BADGE_STATUS}" >> "$GITHUB_OUTPUT"