Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-02-02 22:37:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

[test] Remove redundant circular reference TODO test (#1148)

Browse Source
This commit is contained in:
Christian Byrne
2025-07-22 10:59:30 -07:00
committed by GitHub
parent 27865278da
commit ae8293e2cd
1 changed files with 1 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
test/subgraph/SubgraphNode.test.ts
View File

@@ -337,8 +337,7 @@ describe("SubgraphNode Execution", () => {
})
it("should prevent infinite recursion", () => {
// TODO: This test is currently skipped because cycle detection has a bug
// The fix is to pass 'visited' directly instead of 'new Set(visited)' in SubgraphNode.ts:299
// Cycle detection properly prevents infinite recursion when a subgraph contains itself
const subgraph = createTestSubgraph({ nodeCount: 1 })
const subgraphNode = createTestSubgraphNode(subgraph)
@@ -402,21 +401,6 @@ describe("SubgraphNode Execution", () => {
})
describe("SubgraphNode Edge Cases", () => {
it.todo("should detect circular references", () => {
// TODO: This test is currently skipped because cycle detection has a bug
// The fix is to pass 'visited' directly instead of 'new Set(visited)' in SubgraphNode.ts:299
const subgraph = createTestSubgraph({ nodeCount: 1 })
const subgraphNode = createTestSubgraphNode(subgraph)
// Add subgraph node to its own subgraph (circular reference)
subgraph.add(subgraphNode)
const executableNodes = new Map()
expect(() => {
subgraphNode.getInnerNodes(executableNodes)
}).toThrow(/while flattening subgraph/i)
})
it("should handle deep nesting", () => {
// Create a simpler deep nesting test that works with current implementation
const subgraph = createTestSubgraph({