Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-19 22:09:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve QA_ARTIFACTS path in prompt so Claude gets the literal path

Browse Source 
The escaped \$QA_ARTIFACTS in the heredoc produced literal text
'$QA_ARTIFACTS' in the prompt. Claude's Bash tool didn't reliably
expand this env var, so no screenshots or reports were saved.
Remove the escapes so the heredoc expands the variable to the actual
path (e.g. /home/runner/work/_temp/qa-artifacts).
This commit is contained in:
snomiao
2026-03-18 14:22:29 +00:00
parent b2c31e785f
commit be261a8a86
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
.github/workflows/pr-qa.yaml vendored
View File

@@ -162,11 +162,11 @@ jobs:
- Run: playwright-cli screenshot --filename=<path> (to capture failures)
2. Run the FULL QA test plan from the skill file
3. IMPORTANT: Take a screenshot after EVERY significant interaction to build a video.
Save all screenshots sequentially to \$QA_ARTIFACTS/frames/:
mkdir -p \$QA_ARTIFACTS/frames
playwright-cli screenshot --filename=\$QA_ARTIFACTS/frames/frame-001.png
Save all screenshots sequentially to $QA_ARTIFACTS/frames/:
mkdir -p $QA_ARTIFACTS/frames
playwright-cli screenshot --filename=$QA_ARTIFACTS/frames/frame-001.png
(increment the number for each screenshot: frame-002.png, frame-003.png, etc.)
4. Also save screenshots of failures or notable states into \$QA_ARTIFACTS
4. Also save screenshots of failures or notable states into $QA_ARTIFACTS
5. Save report to $QA_ARTIFACTS as YYYY-MM-DD-NNN-${OS_LOWER}-report.md
Do NOT create a new PR. Do NOT post PR comments. Do NOT commit or push anything.
@@ -195,11 +195,11 @@ jobs:
- Run: playwright-cli goto http://127.0.0.1:8188
- Run: playwright-cli snapshot (after each navigation to get element refs)
- Use: playwright-cli click <ref>, playwright-cli press <key>, etc.
- Run: playwright-cli screenshot --filename=<path> (to save failures into \$QA_ARTIFACTS)
- Run: playwright-cli screenshot --filename=<path> (to save failures into $QA_ARTIFACTS)
3. IMPORTANT: Take a screenshot after EVERY significant interaction to build a video.
Save all screenshots sequentially to \$QA_ARTIFACTS/frames/:
mkdir -p \$QA_ARTIFACTS/frames
playwright-cli screenshot --filename=\$QA_ARTIFACTS/frames/frame-001.png
Save all screenshots sequentially to $QA_ARTIFACTS/frames/:
mkdir -p $QA_ARTIFACTS/frames
playwright-cli screenshot --filename=$QA_ARTIFACTS/frames/frame-001.png
(increment the number for each screenshot: frame-002.png, frame-003.png, etc.)
4. Test the specific UI areas affected by these changes
5. Also do a quick smoke test of core functionality (app loads, canvas renders, sidebar works)