Comfy-Org/ComfyUI_frontend
1
0
Fork 0
mirror of https://github.com/Comfy-Org/ComfyUI_frontend.git synced 2026-04-20 14:30:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: address CodeRabbit review feedback

Browse Source 
- Remove unused keysBySource from store public API
- Fix socketless required input validation (widget-only inputs)

Amp-Thread-ID: https://ampcode.com/threads/T-019c0d45-1155-70d9-830a-ed6e50e23ee8
Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
bymyself
2026-01-29 21:24:16 -08:00
parent 50d339e2ba
commit c330529da8
2 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/composables/graph/useRequiredConnectionValidator.ts
View File

@@ -32,9 +32,8 @@ export function useRequiredConnectionValidator(): void {
for (const inputName of Object.keys(nodeDef.input.required)) {
const slot = node.inputs?.find((s) => s.name === inputName)
if (!slot) continue
const hasConnection = slot.link !== null && slot.link !== undefined
const hasConnection = slot?.link !== null && slot?.link !== undefined
const hasWidgetValue = hasWidgetValueForInput(node, inputName)
if (!hasConnection && !hasWidgetValue) {

1
src/stores/graphErrorStateStore.ts
View File

@@ -135,7 +135,6 @@ export const useGraphErrorStateStore = defineStore('graphErrorState', () => {
version,
errorsByKey,
keysByNode,
keysBySource,
execute,
getErrorsForNode,
hasErrorsForNode,