fix: Break circular dependency with shared constants file

Circular dependency was caused by:
- comfyPageFixture.ts importing testComfySnapToGridGridSize from ComfyPage.ts
- ComfyPage.ts re-exporting comfyPageFixture

Solution:
- Extract testComfySnapToGridGridSize to constants.ts
- Both files import from constants.ts
- Only type-import ComfyPage in comfyPageFixture.ts

Now clean dependency graph with no cycles.
This commit is contained in:
bymyself
2025-11-06 21:28:41 -07:00
parent f306cc9bcb
commit c44c3088c0
3 changed files with 7 additions and 4 deletions

View File

@@ -1589,9 +1589,8 @@ export abstract class ComfyPage {
}
}
export const testComfySnapToGridGridSize = 50
// Re-export fixture from separate file to avoid circular dependencies
// Re-export shared constants and fixture
export { testComfySnapToGridGridSize } from './constants'
export { comfyPageFixture } from './comfyPageFixture'
const makeMatcher = function <T>(

View File

@@ -2,8 +2,8 @@ import { test as base } from '@playwright/test'
import { NodeBadgeMode } from '../../src/types/nodeSource'
import type { ComfyPage } from './ComfyPage'
import { testComfySnapToGridGridSize } from './ComfyPage'
import { ComfyMouse } from './ComfyMouse'
import { testComfySnapToGridGridSize } from './constants'
import { LocalhostComfyPage } from './LocalhostComfyPage'
/**

View File

@@ -0,0 +1,4 @@
/**
* Shared constants for browser tests
*/
export const testComfySnapToGridGridSize = 50