mirror of
https://github.com/Comfy-Org/ComfyUI_frontend.git
synced 2026-04-20 14:30:41 +00:00
refactor: use store-backed widget.hidden/advanced instead of legacy patterns
- groupNode.ts: widget.type = 'hidden' -> widget.hidden = true - domWidget.ts: remove type === 'hidden' check, use this.hidden - shared.ts: options.hidden/advanced -> hidden/advanced - TabNormalInputs.vue: options.hidden/advanced -> hidden/advanced All consumers now use WidgetValueStore-backed properties. Amp-Thread-ID: https://ampcode.com/threads/T-019c2bfd-1372-72cc-a856-18008b2bcdd6 Co-authored-by: Amp <amp@ampcode.com>
This commit is contained in:
@@ -33,10 +33,7 @@ const advancedWidgetsSectionDataList = computed((): NodeWidgetsListList => {
|
||||
.map((node) => {
|
||||
const { widgets = [] } = node
|
||||
const advancedWidgets = widgets
|
||||
.filter(
|
||||
(w) =>
|
||||
!(w.options?.canvasOnly || w.options?.hidden) && w.options?.advanced
|
||||
)
|
||||
.filter((w) => !(w.options?.canvasOnly || w.hidden) && w.advanced)
|
||||
.map((widget) => ({ node, widget }))
|
||||
return { widgets: advancedWidgets, node }
|
||||
})
|
||||
|
||||
@@ -265,8 +265,8 @@ export function computedSectionDataList(nodes: MaybeRefOrGetter<LGraphNode[]>) {
|
||||
(w) =>
|
||||
!(
|
||||
w.options?.canvasOnly ||
|
||||
w.options?.hidden ||
|
||||
(w.options?.advanced && !includesAdvanced.value)
|
||||
w.hidden ||
|
||||
(w.advanced && !includesAdvanced.value)
|
||||
)
|
||||
)
|
||||
.map((widget) => ({ node, widget }))
|
||||
|
||||
@@ -1412,7 +1412,7 @@ export class GroupNodeHandler {
|
||||
handlerGroupData.oldToNewWidgetMap[Number(n)]?.[w]
|
||||
const widget = this.widgets.find((wg) => wg.name === widgetName)
|
||||
if (widget) {
|
||||
widget.type = 'hidden'
|
||||
widget.hidden = true
|
||||
widget.computeSize = () => [0, -4]
|
||||
}
|
||||
}
|
||||
|
||||
@@ -153,7 +153,7 @@ abstract class BaseDOMWidgetImpl<V extends object | string>
|
||||
}
|
||||
|
||||
isVisible(): boolean {
|
||||
return !['hidden'].includes(this.type) && this.node.isWidgetVisible(this)
|
||||
return !this.hidden && this.node.isWidgetVisible(this)
|
||||
}
|
||||
|
||||
override draw(
|
||||
|
||||
Reference in New Issue
Block a user