fix: scope Pages permissions to deploy job, guard genhtml for empty LCOV

2026-04-19 22:09:37 +00:00 · 2026-04-15 20:15:10 -07:00
parent f43d560967
commit ceca6e10d5
1 changed files with 9 additions and 2 deletions
--- a/.github/workflows/ci-tests-e2e-coverage.yaml
+++ b/.github/workflows/ci-tests-e2e-coverage.yaml
@@ -12,8 +12,6 @@ concurrency:

 permissions:
  contents: read
-  pages: write
-  id-token: write

 jobs:
  merge:
@@ -76,6 +74,12 @@ jobs:

      - name: Generate HTML coverage report
        run: |
+          if [ ! -s coverage/playwright/coverage.lcov ]; then
+            echo "No coverage data; generating placeholder report."
+            mkdir -p coverage/html
+            echo '<html><body><h1>No E2E coverage data available for this run.</h1></body></html>' > coverage/html/index.html
+            exit 0
+          fi
          genhtml coverage/playwright/coverage.lcov \
            -o coverage/html \
            --title "ComfyUI E2E Coverage" \
@@ -93,6 +97,9 @@ jobs:
    needs: merge
    if: github.event.workflow_run.head_branch == 'main'
    runs-on: ubuntu-latest
+    permissions:
+      pages: write
+      id-token: write
    environment:
      name: github-pages
      url: ${{ steps.deployment.outputs.page_url }}