Road to No Explicit Any Part 10 (#8499)

## Summary

This PR removes `any` types from UI component files and replaces them
with proper TypeScript types.

### Key Changes

#### Type Safety Improvements
- Replaced `any` with `unknown`, explicit types, or proper interfaces
across UI components
- Used `ComponentPublicInstance` with explicit method signatures for
component refs
- Used `Record<string, unknown>` for dynamic property access
- Added generics for form components with flexible value types
- Used `CSSProperties` for style objects

### Files Changed

UI Components:
- src/components/common/ComfyImage.vue - Used proper class prop type
- src/components/common/DeviceInfo.vue - Used `string | number` for
formatValue
- src/components/common/FormItem.vue - Used `unknown` for model value
- src/components/common/FormRadioGroup.vue - Added generic type
parameter
- src/components/common/TreeExplorer.vue - Used proper async function
signature
- src/components/custom/widget/WorkflowTemplateSelectorDialog.vue -
Fixed duplicate import
- src/components/graph/CanvasModeSelector.vue - Used
`ComponentPublicInstance` for ref
- src/components/node/NodePreview.vue - Changed `any` to `unknown`
- src/components/queue/job/JobDetailsPopover.vue - Removed unnecessary
casts
- src/components/queue/job/JobFiltersBar.vue - Removed `as any` casts
- src/platform/assets/components/MediaAssetContextMenu.vue - Added
`ContextMenuInstance` type
- src/renderer/extensions/minimap/MiniMapPanel.vue - Used
`CSSProperties`
- src/renderer/extensions/vueNodes/composables/useNodeTooltips.ts -
Added `PrimeVueTooltipElement` interface
-
src/renderer/extensions/vueNodes/widgets/components/form/FormSelectButton.vue
- Used `Record<string, unknown>`
-
src/workbench/extensions/manager/components/manager/infoPanel/tabs/DescriptionTabPanel.vue
- Added `LicenseObject` interface

### Testing
- All TypeScript type checking passes (`pnpm typecheck`)
- Linting passes without errors (`pnpm lint`)

Part of the "Road to No Explicit Any" initiative.

### Previous PRs in this series:
- Part 2: #7401
- Part 3: #7935
- Part 4: #7970
- Part 5: #8064
- Part 6: #8083
- Part 7: #8092
- Part 8 Group 1: #8253
- Part 8 Group 2: #8258
- Part 8 Group 3: #8304
- Part 8 Group 4: #8314
- Part 8 Group 5: #8329
- Part 8 Group 6: #8344
- Part 8 Group 7: #8459
- Part 8 Group 8: #8496
- Part 9: #8498
- Part 10: #8499

┆Issue is synchronized with this [Notion
page](https://www.notion.so/PR-8499-Road-to-No-Explicit-Any-Part-10-2f86d73d365081aab129f165c7d02434)
by [Unito](https://www.unito.io)
This commit is contained in:
Johnpaul Chiwetelu
2026-02-02 17:16:40 +01:00
committed by GitHub
parent 7dd3098af5
commit cfdd002b7c
15 changed files with 62 additions and 32 deletions

View File

@@ -38,7 +38,10 @@ const {
alt = 'Image content'
} = defineProps<{
src: string
class?: any
class?:
| string
| Record<string, boolean>
| (string | Record<string, boolean>)[]
contain?: boolean
alt?: string
}>()

View File

@@ -28,13 +28,17 @@ const deviceColumns: { field: keyof DeviceStats; header: string }[] = [
{ field: 'torch_vram_free', header: 'Torch VRAM Free' }
]
const formatValue = (value: any, field: string) => {
const formatValue = (value: string | number, field: string) => {
if (
['vram_total', 'vram_free', 'torch_vram_total', 'torch_vram_free'].includes(
field
)
) {
return formatSize(value)
const num = Number(value)
if (Number.isFinite(num)) {
return formatSize(num)
}
return value
}
return value
}

View File

@@ -47,7 +47,7 @@ import InputSlider from '@/components/common/InputSlider.vue'
import UrlInput from '@/components/common/UrlInput.vue'
import type { FormItem } from '@/platform/settings/types'
const formValue = defineModel<any>('formValue')
const formValue = defineModel<unknown>('formValue')
const props = defineProps<{
item: FormItem
id?: string
@@ -61,7 +61,7 @@ function getFormAttrs(item: FormItem) {
attrs['renderFunction'] = () =>
inputType(
props.item.name,
(v: any) => (formValue.value = v),
(v: unknown) => (formValue.value = v),
formValue.value,
item.attrs
)

View File

@@ -20,14 +20,14 @@
</div>
</template>
<script setup lang="ts">
<script setup lang="ts" generic="T extends string | number | boolean | null">
import RadioButton from 'primevue/radiobutton'
import { computed } from 'vue'
import type { SettingOption } from '@/platform/settings/types'
const props = defineProps<{
modelValue: any
modelValue: T
options?: (string | SettingOption | Record<string, string>)[]
optionLabel?: string
optionValue?: string
@@ -35,7 +35,7 @@ const props = defineProps<{
}>()
defineEmits<{
'update:modelValue': [value: any]
'update:modelValue': [value: T]
}>()
const normalizedOptions = computed<SettingOption[]>(() => {

View File

@@ -221,7 +221,7 @@ const wrapCommandWithErrorHandler = (
) => {
return isAsync
? errorHandling.wrapWithErrorHandlingAsync(
command as (...args: any[]) => Promise<any>,
command as (event: MenuItemCommandEvent) => Promise<void>,
menuTargetNode.value?.handleError
)
: errorHandling.wrapWithErrorHandling(

View File

@@ -412,8 +412,8 @@ import { useTemplateFiltering } from '@/composables/useTemplateFiltering'
import { isCloud } from '@/platform/distribution/types'
import { useTelemetry } from '@/platform/telemetry'
import { useTemplateWorkflows } from '@/platform/workflow/templates/composables/useTemplateWorkflows'
import { useWorkflowTemplatesStore } from '@/platform/workflow/templates/repositories/workflowTemplatesStore'
import type { TemplateInfo } from '@/platform/workflow/templates/types/template'
import { useWorkflowTemplatesStore } from '@/platform/workflow/templates/repositories/workflowTemplatesStore'
import { TemplateIncludeOnDistributionEnum } from '@/platform/workflow/templates/types/template'
import { useSystemStatsStore } from '@/stores/systemStatsStore'
import type { NavGroupData, NavItemData } from '@/types/navTypes'
@@ -794,7 +794,7 @@ watch(
)
// Methods
const onLoadWorkflow = async (template: any) => {
const onLoadWorkflow = async (template: TemplateInfo) => {
loadingTemplate.value = template.name
try {
await loadWorkflowTemplate(

View File

@@ -55,6 +55,7 @@
<script setup lang="ts">
import Popover from 'primevue/popover'
import type { ComponentPublicInstance } from 'vue'
import { computed, ref } from 'vue'
import Button from '@/components/ui/button/Button.vue'
@@ -66,7 +67,7 @@ interface Props {
}
defineProps<Props>()
const buttonRef = ref<InstanceType<typeof Button>>()
const buttonRef = ref<ComponentPublicInstance | null>(null)
const popover = ref<InstanceType<typeof Popover>>()
const commandStore = useCommandStore()
const canvasStore = useCanvasStore()
@@ -92,7 +93,7 @@ const lockCommandText = computed(() =>
)
const toggle = (event: Event) => {
const el = (buttonRef.value as any)?.$el || buttonRef.value
const el = buttonRef.value?.$el || buttonRef.value
popover.value?.toggle(event, el)
}

View File

@@ -124,7 +124,10 @@ const slotInputDefs = allInputDefs.filter(
const widgetInputDefs = allInputDefs.filter((input) =>
widgetStore.inputIsWidget(input)
)
const truncateDefaultValue = (value: any, charLimit: number = 32): string => {
const truncateDefaultValue = (
value: unknown,
charLimit: number = 32
): string => {
let stringValue: string
if (typeof value === 'object' && value !== null) {

View File

@@ -296,7 +296,7 @@ const extraRows = computed<DetailRow[]>(() => {
]
}
if (jobState.value === 'completed') {
const task = taskForJob.value as any
const task = taskForJob.value
const endTs: number | undefined = task?.executionEndTimestamp
const execMs: number | undefined = task?.executionTime
const generatedOnValue = endTs ? formatClockTime(endTs, locale.value) : ''
@@ -321,7 +321,7 @@ const extraRows = computed<DetailRow[]>(() => {
return rows
}
if (jobState.value === 'failed') {
const task = taskForJob.value as any
const task = taskForJob.value
const execMs: number | undefined = task?.executionTime
const failedAfterValue =
execMs !== undefined ? formatElapsedTime(execMs) : ''

View File

@@ -179,7 +179,7 @@ const onFilterClick = (event: Event) => {
}
}
const selectWorkflowFilter = (value: 'all' | 'current') => {
;(filterPopoverRef.value as any)?.hide?.()
filterPopoverRef.value?.hide()
emit('update:selectedWorkflowFilter', value)
}
@@ -190,7 +190,7 @@ const onSortClick = (event: Event) => {
}
const selectSortMode = (value: JobSortMode) => {
;(sortPopoverRef.value as any)?.hide?.()
sortPopoverRef.value?.hide()
emit('update:selectedSortMode', value)
}